drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE
authorLuca Weiss <luca.weiss@fairphone.com>
Thu, 11 Jan 2024 12:38:04 +0000 (13:38 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Mon, 18 Mar 2024 09:05:46 +0000 (10:05 +0100)
Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding
bridge/panel.o to drm_kms_helper object, we need to select
DRM_KMS_HELPER to make sure the file is actually getting built.

Otherwise with certain defconfigs e.g. devm_drm_of_get_bridge will not
be properly available:

  aarch64-linux-gnu-ld: drivers/phy/qualcomm/phy-qcom-qmp-combo.o: in function `qmp_combo_bridge_attach':
  drivers/phy/qualcomm/phy-qcom-qmp-combo.c:3204:(.text+0x8f4): undefined reference to `devm_drm_of_get_bridge'

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Link: https://lore.kernel.org/r/20240111-drm-panel-bridge-fixup-v1-1-e06292f6f500@fairphone.com
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240111-drm-panel-bridge-fixup-v1-1-e06292f6f500@fairphone.com
drivers/gpu/drm/bridge/Kconfig

index efd996f6c13843051316d145e26e0cd9d19749eb..1d4f010af97bb3350b342a1f93ae9b223a2d03bb 100644 (file)
@@ -8,6 +8,7 @@ config DRM_BRIDGE
 config DRM_PANEL_BRIDGE
        def_bool y
        depends on DRM_BRIDGE
+       select DRM_KMS_HELPER
        select DRM_PANEL
        help
          DRM bridge wrapper of DRM panels