Fix use after free in vfio_migration_probe
authorKirti Wankhede <kwankhede@nvidia.com>
Fri, 6 Nov 2020 18:02:24 +0000 (23:32 +0530)
committerAlex Williamson <alex.williamson@redhat.com>
Thu, 12 Nov 2020 22:58:16 +0000 (15:58 -0700)
Fixes Coverity issue:
CID 1436126:  Memory - illegal accesses  (USE_AFTER_FREE)

Fixes: a9e271ec9b36 ("vfio: Add migration region initialization and finalize function")
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: David Edmondson <dme@dme.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
hw/vfio/migration.c

index 3ce285ea395d917d841c2bf0d4b6a5effb40033b..55261562d4f3585bd62e4cd3470092d0a6f84b3b 100644 (file)
@@ -897,8 +897,8 @@ int vfio_migration_probe(VFIODevice *vbasedev, Error **errp)
         goto add_blocker;
     }
 
-    g_free(info);
     trace_vfio_migration_probe(vbasedev->name, info->index);
+    g_free(info);
     return 0;
 
 add_blocker: