scsi: a100u2w: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:28:09 +0000 (13:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:28:44 +0000 (21:28 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-15-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/a100u2w.c

index 028af6b1057c60649f84cb3faa31f2079423ff57..68343bcb4616af4ab5c26d2eea0a2c66401827f6 100644 (file)
@@ -917,7 +917,6 @@ static int inia100_queue_lck(struct scsi_cmnd * cmd, void (*done) (struct scsi_c
        struct orc_host *host;          /* Point to Host adapter control block */
 
        host = (struct orc_host *) cmd->device->host->hostdata;
-       cmd->scsi_done = done;
        /* Get free SCSI control block  */
        if ((scb = orc_alloc_scb(host)) == NULL)
                return SCSI_MLQUEUE_HOST_BUSY;
@@ -1042,7 +1041,7 @@ static void inia100_scb_handler(struct orc_host *host, struct orc_scb *scb)
        }
        cmd->result = scb->tastat | (scb->hastat << 16);
        scsi_dma_unmap(cmd);
-       cmd->scsi_done(cmd);    /* Notify system DONE           */
+       scsi_done(cmd);         /* Notify system DONE           */
        orc_release_scb(host, scb);     /* Release SCB for current channel */
 }