platform/x86/amd/pmf: Do not use readl() for policy buffer access
authorArmin Wolf <W_Armin@gmx.de>
Mon, 4 Mar 2024 20:50:03 +0000 (21:50 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 12 Mar 2024 10:48:03 +0000 (12:48 +0200)
The policy buffer is allocated using normal memory allocation
functions, so readl() should not be used on it.

Compile-tested only.

Fixes: 7c45534afa44 ("platform/x86/amd/pmf: Add support for PMF Policy Binary")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20240304205005.10078-3-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/amd/pmf/tee-if.c

index 13dd4462e1e39c00d95b35d611c90acacb999bba..58ec2c9606e10fb4655d11fa58e577b89dc6a499 100644 (file)
@@ -249,8 +249,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev)
        u32 cookie, length;
        int res;
 
-       cookie = readl(dev->policy_buf + POLICY_COOKIE_OFFSET);
-       length = readl(dev->policy_buf + POLICY_COOKIE_LEN);
+       cookie = *(u32 *)(dev->policy_buf + POLICY_COOKIE_OFFSET);
+       length = *(u32 *)(dev->policy_buf + POLICY_COOKIE_LEN);
 
        if (cookie != POLICY_SIGN_COOKIE || !length)
                return -EINVAL;