media: atomisp: Remove s_routing subdev call
authorHans de Goede <hdegoede@redhat.com>
Thu, 28 Dec 2023 20:28:07 +0000 (21:28 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 1 Feb 2024 06:00:59 +0000 (07:00 +0100)
sensor drivers do not implement the s_routing subdev call, so there is
no use in calling it.

Also the 3 0 arguments are not the arguments which a successful
s_routing call is supposed to take.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_ioctl.c

index 5b2d88c02d36a083376ee21660923635e9ff70c4..bb8e5e883b5080a8e7fc276d49efe6ecdaecb395 100644 (file)
@@ -666,14 +666,6 @@ static int atomisp_s_input(struct file *file, void *fh, unsigned int input)
                return ret;
        }
 
-       /* select operating sensor */
-       ret = v4l2_subdev_call(isp->inputs[input].camera, video, s_routing,
-                              0, 0, 0);
-       if (ret && (ret != -ENOIOCTLCMD)) {
-               dev_err(isp->dev, "Failed to select sensor\n");
-               return ret;
-       }
-
        if (!IS_ISP2401) {
                motor = isp->inputs[input].motor;
        } else {