staging: vt6655: fix camelcase in bShortSlotTime

Replace camel case variable bShortSlotTime with snake case variable
short_slot_time. bShortSlotTime is a boolean variable, if true short
slot time is enabled, false not. Short Slot Time reduces the slot time
from 20 microseconds to 9 microseconds, where the slot time is
the maximum theoretical time for a frame to travel a network.

References:
 - http://cciew.blogspot.com/2011/02/short-slot-time.html
 - https://www.cse.wustl.edu/~jain/cse574-16/ftp/j_05lan4.pdf
 - https://www.networkdatapedia.com/post/2013/09/16/ \
   configuring-short-slot-time-to-improve-wifi-performance
 - https://en.wikipedia.org/wiki/Slot_time

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
Link: https://lore.kernel.org/r/20211005205702.14029-2-tomm.merciai@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index f73f3fad3e05ab28b227c89315ad810be3470fe2..491cf4d8bc6c9165e01c4e1cd24b64e161e6ab8b 100644 (file)
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -2200,7 +2200,7 @@ bb_set_short_slot_time(struct vnt_private *priv)
 
        bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */
 
-       if (priv->bShortSlotTime)
+       if (priv->short_slot_time)
                by_bb_rx_conf &= 0xDF; /* 1101 1111 */
        else
                by_bb_rx_conf |= 0x20; /* 0010 0000 */
@@ -2223,7 +2223,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data)
        /* patch for 3253B0 Baseband with Cardbus module */
        if (by_data == priv->abyBBVGA[0])
                by_bb_rx_conf |= 0x20; /* 0010 0000 */
-       else if (priv->bShortSlotTime)
+       else if (priv->short_slot_time)
                by_bb_rx_conf &= 0xDF; /* 1101 1111 */
        else
                by_bb_rx_conf |= 0x20; /* 0010 0000 */

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 3ef3a6e0e6e1dc0a6344e349b182e2e5c79cd849..7fb8a74e2a7885f1c66b8c4b9567476e0dbe040e 100644 (file)
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -258,7 +258,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
                bb_write_embedded(priv, 0x88, 0x08);
                bySIFS = C_SIFS_BG;
 
-               if (priv->bShortSlotTime) {
+               if (priv->short_slot_time) {
                        bySlot = C_SLOT_SHORT;
                        byDIFS = C_SIFS_BG + 2 * C_SLOT_SHORT;
                } else {

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 2af769174e332149a9dd91dd1f1518e3d224fc8d..49e3d09480f2c8f3cf6e8b4041bcbc119263c2cc 100644 (file)
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -215,7 +215,7 @@ struct vnt_private {
 
        bool bEncryptionEnable;
        bool bLongHeader;
-       bool bShortSlotTime;
+       bool short_slot_time;
        bool bProtectMode;
        bool bNonERPPresent;
        bool bBarkerPreambleMd;

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index d40c2ac1492808953571d790ed085481da788abc..52c2a6651bc9941f200740656d40afee56ed9c0f 100644 (file)
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1440,9 +1440,9 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
 
        if (changed & BSS_CHANGED_ERP_SLOT) {
                if (conf->use_short_slot)
-                       priv->bShortSlotTime = true;
+                       priv->short_slot_time = true;
                else
-                       priv->bShortSlotTime = false;
+                       priv->short_slot_time = false;
 
                CARDbSetPhyParameter(priv, priv->byBBType);
                bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);