media: pvrusb2: Do not check for V4L2_CTRL_WHICH_DEF_VAL
authorRicardo Ribalda <ribalda@chromium.org>
Fri, 18 Jun 2021 12:29:04 +0000 (14:29 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:07:46 +0000 (10:07 +0200)
The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
written.

Cc: Mike Isely <isely@pobox.com>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c

index 9657c188331166eaa790d75f5dec1284bafaa70d..c04ab7258d645266c05bf9adc117566e9a1d962e 100644 (file)
@@ -640,10 +640,6 @@ static int pvr2_s_ext_ctrls(struct file *file, void *priv,
        unsigned int idx;
        int ret;
 
-       /* Default value cannot be changed */
-       if (ctls->which == V4L2_CTRL_WHICH_DEF_VAL)
-               return -EINVAL;
-
        ret = 0;
        for (idx = 0; idx < ctls->count; idx++) {
                ctrl = ctls->controls + idx;