platform/x86: ISST: Use in_range() to check package ID validity
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tue, 23 Apr 2024 20:46:17 +0000 (13:46 -0700)
committerHans de Goede <hdegoede@redhat.com>
Mon, 29 Apr 2024 11:01:48 +0000 (13:01 +0200)
Use in_range() macro to simplify range check.

No functional impact is expected.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240423204619.3946901-9-srinivas.pandruvada@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c

index b8da6847622b258ab217353e0c06177aa76c025e..e75fb9eba598be1dc314305f740979a582a218f6 100644 (file)
@@ -531,8 +531,7 @@ static struct tpmi_per_power_domain_info *get_instance(int pkg_id, int power_dom
        struct tpmi_sst_struct *sst_inst;
        u8 part;
 
-       if (pkg_id < 0 || pkg_id > isst_common.max_index ||
-           pkg_id >= topology_max_packages())
+       if (!in_range(pkg_id, 0, topology_max_packages()) || pkg_id > isst_common.max_index)
                return NULL;
 
        sst_inst = isst_common.sst_inst[pkg_id];