virt: sevguest: Fix return value check in alloc_shared_pages()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 11 Apr 2022 11:12:13 +0000 (19:12 +0800)
committerBorislav Petkov <bp@suse.de>
Mon, 11 Apr 2022 15:58:52 +0000 (17:58 +0200)
If alloc_pages() fails, it returns a NULL pointer. Replace the wrong
IS_ERR() check with the proper NULL pointer check.

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Link: https://lore.kernel.org/r/20220411111213.1477853-1-yangyingliang@huawei.com
drivers/virt/coco/sevguest/sevguest.c

index 15afb6ce8d19b9ef0d105fb8cef44728ccc69edd..aaa6134d1d402c4b1c724d0b3c73fd4ff8afecb4 100644 (file)
@@ -581,7 +581,7 @@ static void *alloc_shared_pages(size_t sz)
        int ret;
 
        page = alloc_pages(GFP_KERNEL_ACCOUNT, get_order(sz));
-       if (IS_ERR(page))
+       if (!page)
                return NULL;
 
        ret = set_memory_decrypted((unsigned long)page_address(page), npages);