can: m_can: remove redundant check for pm_clock_support
authorFrancesco Dolcini <francesco.dolcini@toradex.com>
Thu, 4 Jan 2024 23:57:23 +0000 (00:57 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 14 Feb 2024 10:24:30 +0000 (11:24 +0100)
m_can_clk_start() already skip starting the clock when
clock support is disabled, remove the redundant check in
m_can_class_register().

This also solves the imbalance with m_can_clk_stop() that is called
afterward in the same function before the return.

Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Link: https://lore.kernel.org/all/20240104235723.46931-1-francesco@dolcini.it
[mkl: rebased to net-next/main]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c

index b7dbce4c342a7ac51dfee88b1fb31fa23a41d695..290880ce5329c1434c9025e1099dac5d5d5f6561 100644 (file)
@@ -2312,11 +2312,9 @@ int m_can_class_register(struct m_can_classdev *cdev)
                }
        }
 
-       if (cdev->pm_clock_support) {
-               ret = m_can_clk_start(cdev);
-               if (ret)
-                       return ret;
-       }
+       ret = m_can_clk_start(cdev);
+       if (ret)
+               return ret;
 
        if (cdev->is_peripheral) {
                ret = can_rx_offload_add_manual(cdev->net, &cdev->offload,