ARM: dts: exynos: correct PMIC interrupt trigger level on Midas family
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:21 +0000 (22:25 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Sun, 7 Mar 2021 19:56:17 +0000 (20:56 +0100)
The Maxim PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: 15dfdfad2d4a ("ARM: dts: Add basic dts for Exynos4412-based Trats 2 board")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-5-krzk@kernel.org
arch/arm/boot/dts/exynos4412-midas.dtsi

index d75f554efde05f21c8ef056511f5124c4e9a6a46..fc77c1bfd844e654c25a160d84c651c9c508437f 100644 (file)
        max77686: pmic@9 {
                compatible = "maxim,max77686";
                interrupt-parent = <&gpx0>;
-               interrupts = <7 IRQ_TYPE_NONE>;
+               interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
                pinctrl-0 = <&max77686_irq>;
                pinctrl-names = "default";
                reg = <0x09>;