mmc: sdhci-pci-o2micro: Fix card detect by dealing with debouncing
authorChevron Li <chevron.li@bayhubtech.com>
Thu, 2 Jun 2022 13:25:43 +0000 (06:25 -0700)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 14 Jun 2022 20:52:53 +0000 (13:52 -0700)
The result from ->get_cd() may be incorrect as the card detect debouncing
isn't managed correctly. Let's fix it.

Signed-off-by: Chevron Li<chevron.li@bayhubtech.com>
Fixes: 7d44061704dd ("mmc: sdhci-pci-o2micro: Fix O2 Host data read/write DLL Lock phase shift issue")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220602132543.596-1-chevron.li@bayhubtech.com
[Ulf: Updated the commit message]
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pci-o2micro.c

index 92c20cb8074a68e2a6dbb6a64dc1163d9608e882..0d4d343dbb77d19774d08f6eba2d798e68948eea 100644 (file)
@@ -152,6 +152,8 @@ static int sdhci_o2_get_cd(struct mmc_host *mmc)
 
        if (!(sdhci_readw(host, O2_PLL_DLL_WDT_CONTROL1) & O2_PLL_LOCK_STATUS))
                sdhci_o2_enable_internal_clock(host);
+       else
+               sdhci_o2_wait_card_detect_stable(host);
 
        return !!(sdhci_readl(host, SDHCI_PRESENT_STATE) & SDHCI_CARD_PRESENT);
 }