dmaengine: ste_dma40: Pass dev to OF function
authorLinus Walleij <linus.walleij@linaro.org>
Tue, 16 May 2023 12:55:35 +0000 (14:55 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 16 May 2023 17:30:19 +0000 (23:00 +0530)
The OF platform data population function only wants to
use struct device *dev, so pass that instead.

This change makes the compiler realize that the local
platform data variable is unused, so drop that too.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230417-ux500-dma40-cleanup-v3-5-60bfa6785968@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ste_dma40.c

index 48c9606cfd46d1f7e5c3bd153e7ad3ec83810cc7..87f57457e4d94c278312492b98bd6b4bb41b1ca0 100644 (file)
@@ -3480,14 +3480,14 @@ static int __init d40_lcla_allocate(struct d40_base *base)
        return ret;
 }
 
-static int __init d40_of_probe(struct platform_device *pdev,
+static int __init d40_of_probe(struct device *dev,
                               struct device_node *np)
 {
        struct stedma40_platform_data *pdata;
        int num_phy = 0, num_memcpy = 0, num_disabled = 0;
        const __be32 *list;
 
-       pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
+       pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
        if (!pdata)
                return -ENOMEM;
 
@@ -3500,7 +3500,7 @@ static int __init d40_of_probe(struct platform_device *pdev,
        num_memcpy /= sizeof(*list);
 
        if (num_memcpy > D40_MEMCPY_MAX_CHANS || num_memcpy <= 0) {
-               d40_err(&pdev->dev,
+               d40_err(dev,
                        "Invalid number of memcpy channels specified (%d)\n",
                        num_memcpy);
                return -EINVAL;
@@ -3515,7 +3515,7 @@ static int __init d40_of_probe(struct platform_device *pdev,
        num_disabled /= sizeof(*list);
 
        if (num_disabled >= STEDMA40_MAX_PHYS || num_disabled < 0) {
-               d40_err(&pdev->dev,
+               d40_err(dev,
                        "Invalid number of disabled channels specified (%d)\n",
                        num_disabled);
                return -EINVAL;
@@ -3526,7 +3526,7 @@ static int __init d40_of_probe(struct platform_device *pdev,
                                   num_disabled);
        pdata->disabled_channels[num_disabled] = -1;
 
-       pdev->dev.platform_data = pdata;
+       dev->platform_data = pdata;
 
        return 0;
 }
@@ -3534,7 +3534,6 @@ static int __init d40_of_probe(struct platform_device *pdev,
 static int __init d40_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct stedma40_platform_data *plat_data = dev_get_platdata(dev);
        struct device_node *np = pdev->dev.of_node;
        struct device_node *np_lcpa;
        int ret = -ENOENT;
@@ -3544,7 +3543,7 @@ static int __init d40_probe(struct platform_device *pdev)
        int num_reserved_chans;
        u32 val;
 
-       if (d40_of_probe(pdev, np)) {
+       if (d40_of_probe(dev, np)) {
                ret = -ENOMEM;
                goto report_failure;
        }