ata: ahci: Rename `AHCI_HFLAG_IS_MOBILE`
authorMario Limonciello <mario.limonciello@amd.com>
Fri, 25 Feb 2022 17:23:18 +0000 (11:23 -0600)
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>
Tue, 1 Mar 2022 14:51:13 +0000 (23:51 +0900)
`AHCI_HFLAG_IS_MOBILE` designates that a chipset should be using the
default link power management policy from a kernel configuration item.

As desktop chipsets may also be interested in this default policy
configuration, rename the flag to `AHCI_HFLAG_USE_LPM_POLICY` to more
accurately reflect that a chipset doesn't have to be mobile to adopt it.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
drivers/ata/ahci.c
drivers/ata/ahci.h

index c31fae2b384e668dcae8fb16e1a9d2efb67449ed..397dfd27c90d4fc6a252532770d8ebb04a487071 100644 (file)
@@ -136,7 +136,7 @@ static const struct ata_port_info ahci_port_info[] = {
                .port_ops       = &ahci_ops,
        },
        [board_ahci_low_power] = {
-               AHCI_HFLAGS     (AHCI_HFLAG_IS_MOBILE),
+               AHCI_HFLAGS     (AHCI_HFLAG_USE_LPM_POLICY),
                .flags          = AHCI_FLAG_COMMON,
                .pio_mask       = ATA_PIO4,
                .udma_mask      = ATA_UDMA6,
@@ -1598,8 +1598,8 @@ static void ahci_update_initial_lpm_policy(struct ata_port *ap,
        int policy = CONFIG_SATA_MOBILE_LPM_POLICY;
 
 
-       /* Ignore processing for non mobile platforms */
-       if (!(hpriv->flags & AHCI_HFLAG_IS_MOBILE))
+       /* Ignore processing for chipsets that don't use policy */
+       if (!(hpriv->flags & AHCI_HFLAG_USE_LPM_POLICY))
                return;
 
        /* user modified policy via module param */
index eeac5482f1d1acb554dc2c029aa858a9fe184a88..1ad48e2fe57369145cdd60d394507dcad7bffb9f 100644 (file)
@@ -235,7 +235,7 @@ enum {
        AHCI_HFLAG_YES_ALPM             = (1 << 23), /* force ALPM cap on */
        AHCI_HFLAG_NO_WRITE_TO_RO       = (1 << 24), /* don't write to read
                                                        only registers */
-       AHCI_HFLAG_IS_MOBILE            = (1 << 25), /* mobile chipset, use
+       AHCI_HFLAG_USE_LPM_POLICY       = (1 << 25), /* chipset that should use
                                                        SATA_MOBILE_LPM_POLICY
                                                        as default lpm_policy */
        AHCI_HFLAG_SUSPEND_PHYS         = (1 << 26), /* handle PHYs during