wifi: ath12k: Remove unnecessary (void*) conversions

No need cast (void*) to (struct hal_rx_ppdu_end_user_stats *),
(struct ath12k_rx_desc_info *) or (struct hal_tx_msdu_ext_desc *).
Change the prototype to remove the local variable.

Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
Suggested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230919045142.524226-1-yunchuan@nfschina.com

diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c
index f1e57e98bdc60d6f69b5113895faa6e51ea67672..1698a771249459a0e682bfdef8510064d02e7fa1 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/dp_mon.c
+++ b/drivers/net/wireless/ath/ath12k/dp_mon.c
@@ -13,8 +13,7 @@
 static void ath12k_dp_mon_rx_handle_ofdma_info(void *rx_tlv,
                                               struct hal_rx_user_status *rx_user_status)
 {
-       struct hal_rx_ppdu_end_user_stats *ppdu_end_user =
-                               (struct hal_rx_ppdu_end_user_stats *)rx_tlv;
+       struct hal_rx_ppdu_end_user_stats *ppdu_end_user = rx_tlv;
 
        rx_user_status->ul_ofdma_user_v0_word0 =
                __le32_to_cpu(ppdu_end_user->usr_resp_ref);
@@ -23,13 +22,12 @@ static void ath12k_dp_mon_rx_handle_ofdma_info(void *rx_tlv,
 }
 
 static void
-ath12k_dp_mon_rx_populate_byte_count(void *rx_tlv, void *ppduinfo,
+ath12k_dp_mon_rx_populate_byte_count(const struct hal_rx_ppdu_end_user_stats *stats,
+                                    void *ppduinfo,
                                     struct hal_rx_user_status *rx_user_status)
 {
-       struct hal_rx_ppdu_end_user_stats *ppdu_end_user =
-               (struct hal_rx_ppdu_end_user_stats *)rx_tlv;
-       u32 mpdu_ok_byte_count = __le32_to_cpu(ppdu_end_user->mpdu_ok_cnt);
-       u32 mpdu_err_byte_count = __le32_to_cpu(ppdu_end_user->mpdu_err_cnt);
+       u32 mpdu_ok_byte_count = __le32_to_cpu(stats->mpdu_ok_cnt);
+       u32 mpdu_err_byte_count = __le32_to_cpu(stats->mpdu_err_cnt);
 
        rx_user_status->mpdu_ok_byte_count =
                u32_get_bits(mpdu_ok_byte_count,

diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index e1c84fc9746088bb0d672973c8a188d2834d94a0..39ef3c0d2e65cc00835e40b148aa2d246439cc29 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -3756,7 +3756,7 @@ int ath12k_dp_rx_process_wbm_err(struct ath12k_base *ab,
                        continue;
                }
 
-               desc_info = (struct ath12k_rx_desc_info *)err_info.rx_desc;
+               desc_info = err_info.rx_desc;
 
                /* retry manual desc retrieval if hw cc is not done */
                if (!desc_info) {

diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c
index 16d889fc204333d85ec246e9ac57357175850e21..f5e0f54262268500e6fb2141eb8bf19e2478d1d0 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_tx.c
@@ -106,11 +106,10 @@ static struct ath12k_tx_desc_info *ath12k_dp_tx_assign_buffer(struct ath12k_dp *
        return desc;
 }
 
-static void ath12k_hal_tx_cmd_ext_desc_setup(struct ath12k_base *ab, void *cmd,
+static void ath12k_hal_tx_cmd_ext_desc_setup(struct ath12k_base *ab,
+                                            struct hal_tx_msdu_ext_desc *tcl_ext_cmd,
                                             struct hal_tx_info *ti)
 {
-       struct hal_tx_msdu_ext_desc *tcl_ext_cmd = (struct hal_tx_msdu_ext_desc *)cmd;
-
        tcl_ext_cmd->info0 = le32_encode_bits(ti->paddr,
                                              HAL_TX_MSDU_EXT_INFO0_BUF_PTR_LO);
        tcl_ext_cmd->info1 = le32_encode_bits(0x0,