crypto: hisilicon/qm - add missing pci_dev_put() in q_num_set()

[ Upstream commit cc7710d0d4ebc6998f04035cde4f32c5ddbe9d7f ]

pci_get_device() will increase the reference count for the returned
pci_dev. We need to use pci_dev_put() to decrease the reference count
before q_num_set() returns.

Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Reviewed-by: Weili Qian <qianweili@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/crypto/hisilicon/qm.h b/drivers/crypto/hisilicon/qm.h
index 3068093229a506e749f1c444a441f6b351136a9c..bbb35de994eb7f30e09e7d216d1a1a18d158cce8 100644 (file)
--- a/drivers/crypto/hisilicon/qm.h
+++ b/drivers/crypto/hisilicon/qm.h
@@ -318,14 +318,14 @@ struct hisi_qp {
 static inline int q_num_set(const char *val, const struct kernel_param *kp,
                            unsigned int device)
 {
-       struct pci_dev *pdev = pci_get_device(PCI_VENDOR_ID_HUAWEI,
-                                             device, NULL);
+       struct pci_dev *pdev;
        u32 n, q_num;
        int ret;
 
        if (!val)
                return -EINVAL;
 
+       pdev = pci_get_device(PCI_VENDOR_ID_HUAWEI, device, NULL);
        if (!pdev) {
                q_num = min_t(u32, QM_QNUM_V1, QM_QNUM_V2);
                pr_info("No device found currently, suppose queue number is %u\n",
@@ -335,6 +335,8 @@ static inline int q_num_set(const char *val, const struct kernel_param *kp,
                        q_num = QM_QNUM_V1;
                else
                        q_num = QM_QNUM_V2;
+
+               pci_dev_put(pdev);
        }
 
        ret = kstrtou32(val, 10, &n);