power: supply: cpcap: Add missing IRQF_ONESHOT to fix regression
authorTony Lindgren <tony@atomide.com>
Wed, 30 Dec 2020 10:19:11 +0000 (12:19 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sat, 2 Jan 2021 22:57:44 +0000 (23:57 +0100)
Commit 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT") started causing
errors loading phy-cpcap-usb driver:

cpcap_battery cpcap_battery.0: failed to register power supply
genirq: Flags mismatch irq 211. 00002080 (se0conn) vs. 00000080 (se0conn)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq se0conn: -16

Let's fix this by adding the missing IRQF_ONESHOT to also cpcap-battery
and cpcap-charger drivers.

Fixes: 25d76fed7ffe ("phy: cpcap-usb: Use IRQF_ONESHOT")
Reported-by: Merlijn Wajer <merlijn@wizzup.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/cpcap-battery.c
drivers/power/supply/cpcap-charger.c

index 6745a32ca099086b067be176ff6df0288a1e9502..00c2d0136175b0a34c97b6878cecfe6aefa01613 100644 (file)
@@ -673,7 +673,7 @@ static int cpcap_battery_init_irq(struct platform_device *pdev,
 
        error = devm_request_threaded_irq(ddata->dev, irq, NULL,
                                          cpcap_battery_irq_thread,
-                                         IRQF_SHARED,
+                                         IRQF_SHARED | IRQF_ONESHOT,
                                          name, ddata);
        if (error) {
                dev_err(ddata->dev, "could not get irq %s: %i\n",
index c0d452e3dc8b06cd7abc62b118f63b78bd408888..804ac7f84c301082589ab032d0378f3048fc086b 100644 (file)
@@ -708,7 +708,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
 
        error = devm_request_threaded_irq(ddata->dev, irq, NULL,
                                          cpcap_charger_irq_thread,
-                                         IRQF_SHARED,
+                                         IRQF_SHARED | IRQF_ONESHOT,
                                          name, ddata);
        if (error) {
                dev_err(ddata->dev, "could not get irq %s: %i\n",