spi: pic32: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 30 Apr 2024 11:41:37 +0000 (13:41 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 30 Apr 2024 14:57:30 +0000 (23:57 +0900)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430114142.28551-6-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pic32.c

index 709edb70ad7d378238d9ee29c94e8d5bc918c174..b8bcc220e96d61cbe4423bf0a6b141e3a1acb230 100644 (file)
@@ -498,7 +498,7 @@ static int pic32_spi_one_transfer(struct spi_controller *host,
 {
        struct pic32_spi *pic32s;
        bool dma_issued = false;
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        pic32s = spi_controller_get_devdata(host);
@@ -545,8 +545,8 @@ static int pic32_spi_one_transfer(struct spi_controller *host,
        }
 
        /* wait for completion */
-       timeout = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&pic32s->xfer_done, 2 * HZ);
+       if (time_left == 0) {
                dev_err(&spi->dev, "wait error/timedout\n");
                if (dma_issued) {
                        dmaengine_terminate_all(host->dma_rx);