iio: addac: ad74413r: update channel function set

According to the datasheet switching to a new channel function implies
multiple steps.

All functions must be selected for a minimum of 130 μs before changing
to another function.
The DAC_CODEx registers are not reset by changing channel functions.
Prior to changing channel functions, it is recommended to set the DAC
code to 0x0000 via the DAC_CODEx registers. Set the channel function
to high impedance via the CH_FUNC_SETUPx registers before transitioning
to the new channel function. After the new channel function is configured,
it is recommended to wait 150 μs before updating the DAC code.

Even though the channel switch is done at only at probe, where a device
reset is performed, that does not guarantee that the steps prior
changing to new channel function should be neglected.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20230911142950.216687-1-antoniu.miclaus@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c
index 75216ece7ad63611b29dc8b60d11b06b227a4d83..7af3e4b8fe3bb9ae03449e19a55c1a63a432a8c5 100644 (file)
--- a/drivers/iio/addac/ad74413r.c
+++ b/drivers/iio/addac/ad74413r.c
@@ -441,12 +441,30 @@ static int ad74413r_set_channel_function(struct ad74413r_state *st,
 {
        int ret;
 
+       ret = regmap_update_bits(st->regmap,
+                                AD74413R_REG_CH_FUNC_SETUP_X(channel),
+                                AD74413R_CH_FUNC_SETUP_MASK,
+                                CH_FUNC_HIGH_IMPEDANCE);
+       if (ret)
+               return ret;
+
+       /* Set DAC code to 0 prior to changing channel function */
+       ret = ad74413r_set_channel_dac_code(st, channel, 0);
+       if (ret)
+               return ret;
+
+       /* Delay required before transition to new desired mode */
+       usleep_range(130, 150);
+
        ret = regmap_update_bits(st->regmap,
                                  AD74413R_REG_CH_FUNC_SETUP_X(channel),
                                  AD74413R_CH_FUNC_SETUP_MASK, func);
        if (ret)
                return ret;
 
+       /* Delay required before updating the new DAC code */
+       usleep_range(150, 170);
+
        if (func == CH_FUNC_CURRENT_INPUT_LOOP_POWER)
                ret = regmap_set_bits(st->regmap,
                                      AD74413R_REG_ADC_CONFIG_X(channel),