arm64: dts: qcom: msm8916: Remove one more thermal trip point unit name
authorStephan Gerhold <stephan@gerhold.net>
Tue, 15 Sep 2020 07:12:09 +0000 (09:12 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 15 Sep 2020 15:33:00 +0000 (15:33 +0000)
Commit fe2aff0c574d2 ("arm64: dts: qcom: msm8916: remove unit name for thermal trip points")
removed the unit names for most of the thermal trip points defined
in msm8916.dtsi, but missed to update the one for cpu0_1-thermal.

So why wasn't this spotted by "make dtbs_check"? Apparently, the name
of the thermal zone is already invalid: thermal-zones.yaml specifies
a regex of ^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$, so it is not allowed
to contain underscores. Therefore the thermal zone was never verified
using the DTB schema.

After replacing the underscore in the thermal zone name, the warning
shows up:

    apq8016-sbc.dt.yaml: thermal-zones: cpu0-1-thermal:trips: 'trip-point@0'
    does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-_]{0,63}$', 'pinctrl-[0-9]+'

Fix up the thermal zone names and remove the unit name for the trip point.

Cc: Amit Kucheria <amit.kucheria@linaro.org>
Fixes: fe2aff0c574d2 ("arm64: dts: qcom: msm8916: remove unit name for thermal trip points")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200915071221.72895-3-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/msm8916.dtsi

index d6a5b60846d9c88e54b7c2787fdb22b3f79f0799..d84118fb44033f87f5593963a86f9d8db9c1a727 100644 (file)
        };
 
        thermal-zones {
-               cpu0_1-thermal {
+               cpu0-1-thermal {
                        polling-delay-passive = <250>;
                        polling-delay = <1000>;
 
                        thermal-sensors = <&tsens 5>;
 
                        trips {
-                               cpu0_1_alert0: trip-point@0 {
+                               cpu0_1_alert0: trip-point0 {
                                        temperature = <75000>;
                                        hysteresis = <2000>;
                                        type = "passive";
                        };
                };
 
-               cpu2_3-thermal {
+               cpu2-3-thermal {
                        polling-delay-passive = <250>;
                        polling-delay = <1000>;