peci: constify the struct device_type usage

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the
peci_controller_type and peci_device_type variables to be constant
structures as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: "Ricardo B. Marliere" <ricardo@marliere.net>
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Link: https://lore.kernel.org/r/20240219-device_cleanup-peci-v1-1-0727662616f7@marliere.net
Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>

diff --git a/drivers/peci/core.c b/drivers/peci/core.c
index b2f8db967e9b5daaacd92c7c062a35073cd9465b..8f8bda2f2a62e47f1096ad3a1ab610a91739a026 100644 (file)
--- a/drivers/peci/core.c
+++ b/drivers/peci/core.c
@@ -25,7 +25,7 @@ static void peci_controller_dev_release(struct device *dev)
        kfree(controller);
 }
 
-struct device_type peci_controller_type = {
+const struct device_type peci_controller_type = {
        .release        = peci_controller_dev_release,
 };
 

diff --git a/drivers/peci/device.c b/drivers/peci/device.c
index e6b0bffb14f4131676ff12d489f46335204467e1..ee01f03c29b79252345d81972593280c7c85aed1 100644 (file)
--- a/drivers/peci/device.c
+++ b/drivers/peci/device.c
@@ -246,7 +246,7 @@ static void peci_device_release(struct device *dev)
        kfree(device);
 }
 
-struct device_type peci_device_type = {
+const struct device_type peci_device_type = {
        .groups         = peci_device_groups,
        .release        = peci_device_release,
 };

diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h
index 8a896c256c5f2af8f4a326544af2346683a6d6d3..506bafcccbbf954443e4f57d5118d243bd255761 100644 (file)
--- a/drivers/peci/internal.h
+++ b/drivers/peci/internal.h
@@ -75,7 +75,7 @@ struct peci_device_id {
        u8 model;
 };
 
-extern struct device_type peci_device_type;
+extern const struct device_type peci_device_type;
 extern const struct attribute_group *peci_device_groups[];
 
 int peci_device_create(struct peci_controller *controller, u8 addr);
@@ -129,7 +129,7 @@ void peci_driver_unregister(struct peci_driver *driver);
 #define module_peci_driver(__peci_driver) \
        module_driver(__peci_driver, peci_driver_register, peci_driver_unregister)
 
-extern struct device_type peci_controller_type;
+extern const struct device_type peci_controller_type;
 
 int peci_controller_scan_devices(struct peci_controller *controller);