softmmu/memory: fix memory_region_ioeventfd_equal()
authorElena Afanasova <eafanasova@gmail.com>
Mon, 19 Oct 2020 20:20:13 +0000 (13:20 -0700)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 3 Nov 2020 18:55:13 +0000 (18:55 +0000)
Eventfd can be registered with a zero length when fast_mmio is true.
Handle this case properly when dispatching through QEMU.

Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
Message-id: cf71a62eb04e61932ff8ffdd02e0b2aab4f495a0.camel@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
softmmu/memory.c

index 21d533d8ed841a60ad13c062d90ad33a94dd7bab..8aba4114cffb9592c5c4d598ddf2fad8f9ad1afc 100644 (file)
@@ -205,8 +205,15 @@ static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd *a,
 static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd *a,
                                           MemoryRegionIoeventfd *b)
 {
-    return !memory_region_ioeventfd_before(a, b)
-        && !memory_region_ioeventfd_before(b, a);
+    if (int128_eq(a->addr.start, b->addr.start) &&
+        (!int128_nz(a->addr.size) || !int128_nz(b->addr.size) ||
+         (int128_eq(a->addr.size, b->addr.size) &&
+          (a->match_data == b->match_data) &&
+          ((a->match_data && (a->data == b->data)) || !a->match_data) &&
+          (a->e == b->e))))
+        return true;
+
+    return false;
 }
 
 /* Range of memory in the global map.  Addresses are absolute. */