wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
authorMarek Vasut <marex@denx.de>
Sat, 27 May 2023 22:28:59 +0000 (00:28 +0200)
committerKalle Valo <kvalo@kernel.org>
Thu, 8 Jun 2023 16:02:14 +0000 (19:02 +0300)
It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
indicates to the MMC subsystem to keep the slot powered on during
suspend, but in shutdown the slot should actually be powered off.
Drop this call.

Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230527222859.273768-1-marex@denx.de
drivers/net/wireless/rsi/rsi_91x_sdio.c

index 6e33a2563fdbd840ee744876a8ad70ceef53c422..1911fef3bbad6357060060b0bc5ad4b2417abf89 100644 (file)
@@ -1479,9 +1479,6 @@ static void rsi_shutdown(struct device *dev)
        if (sdev->write_fail)
                rsi_dbg(INFO_ZONE, "###### Device is not ready #######\n");
 
-       if (rsi_set_sdio_pm_caps(adapter))
-               rsi_dbg(INFO_ZONE, "Setting power management caps failed\n");
-
        rsi_dbg(INFO_ZONE, "***** RSI module shut down *****\n");
 }