netrom: Fix a data-race around sysctl_netrom_transport_maximum_tries
authorJason Xing <kernelxing@tencent.com>
Mon, 4 Mar 2024 08:20:39 +0000 (16:20 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 7 Mar 2024 09:36:58 +0000 (10:36 +0100)
We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/netrom/af_netrom.c

index 4d0e0834d527beadada324ebb0edab5f58bb0d0c..312fc745db7ff1d40a2ee5b843c9184b8221547f 100644 (file)
@@ -457,7 +457,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol,
        nr->t2     =
                msecs_to_jiffies(sysctl_netrom_transport_acknowledge_delay);
        nr->n2     =
-               msecs_to_jiffies(sysctl_netrom_transport_maximum_tries);
+               msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_maximum_tries));
        nr->t4     =
                msecs_to_jiffies(sysctl_netrom_transport_busy_delay);
        nr->idle   =