peci: aspeed: fix error check return value of platform_get_irq()
authorLv Ruyi <lv.ruyi@zte.com.cn>
Wed, 13 Apr 2022 01:04:25 +0000 (01:04 +0000)
committerIwona Winiarska <iwona.winiarska@intel.com>
Mon, 15 Aug 2022 18:31:34 +0000 (20:31 +0200)
platform_get_irq() return negative value on failure, so null check of
priv->irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: a85e4c52086c ("peci: Add peci-aspeed controller driver")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220413010425.2534887-1-lv.ruyi@zte.com.cn
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
drivers/peci/controller/peci-aspeed.c

index 1925ddc13f002badd78274e698c4afd2ef5e2675..731c5d8f75c66a3a4865f48e640dcd6d85a3e69f 100644 (file)
@@ -523,7 +523,7 @@ static int aspeed_peci_probe(struct platform_device *pdev)
                return PTR_ERR(priv->base);
 
        priv->irq = platform_get_irq(pdev, 0);
-       if (!priv->irq)
+       if (priv->irq < 0)
                return priv->irq;
 
        ret = devm_request_irq(&pdev->dev, priv->irq, aspeed_peci_irq_handler,