rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx()
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fri, 15 Dec 2017 18:41:54 +0000 (18:41 +0000)
committerJason Wang <jasowang@redhat.com>
Fri, 22 Dec 2017 02:01:27 +0000 (10:01 +0800)
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/rtl8139.c

index a6b2a9f7a4bc6a8e7fa7df9f535034853df70a22..1cc95b8cba86604048b5523c6986859b2c67f8f1 100644 (file)
@@ -882,7 +882,7 @@ static ssize_t rtl8139_do_receive(NetClientState *nc, const uint8_t *buf, size_t
                 return size;
             }
 
-            int mcast_idx = compute_mcast_idx(buf);
+            int mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
 
             if (!(s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))))
             {