staging: r8188eu: voq_cnt is write-only

voq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove voq_cnt and resulting dead code.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Acked-by: Pavel Skripkin <paskripkin@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 031f094f60d04dbaf88e6908ca0ffd9ee07f2243..d1931f2b8b551bee7777ab361b1f7fa0ed5c44cb 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -194,9 +194,6 @@ int _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
 
        pxmitpriv->txirp_cnt = 1;
 
-       /* per AC pending irp */
-       pxmitpriv->voq_cnt = 0;
-
        pxmitpriv->ack_tx = false;
        mutex_init(&pxmitpriv->ack_tx_mutex);
        rtw_sctx_init(&pxmitpriv->ack_tx_ops, 0);

diff --git a/drivers/staging/r8188eu/include/rtw_xmit.h b/drivers/staging/r8188eu/include/rtw_xmit.h
index 71382f97a06e47fde416beb4d6ec542f153e3f4e..1588adadedd6034117172f853dd9c304d18e011d 100644 (file)
--- a/drivers/staging/r8188eu/include/rtw_xmit.h
+++ b/drivers/staging/r8188eu/include/rtw_xmit.h
@@ -282,8 +282,6 @@ struct      xmit_priv {
                                 * 1->vi, 2->be, 3->bk. */
        u8              txirp_cnt;/*  */
        struct tasklet_struct xmit_tasklet;
-       /* per AC pending irp */
-       int voq_cnt;
        struct __queue free_xmitbuf_queue;
        struct __queue pending_xmitbuf_queue;
        u8 *pallocated_xmitbuf;

diff --git a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
index 7929b7d5e89eaefeea54a634d4afe82255ead767..6fe5a42302913760a8ee2117dbfc3f1177a36d14 100644 (file)
--- a/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
+++ b/drivers/staging/r8188eu/os_dep/usb_ops_linux.c
@@ -42,9 +42,6 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs)
        struct xmit_priv        *pxmitpriv = &padapter->xmitpriv;
 
        switch (pxmitbuf->flags) {
-       case VO_QUEUE_INX:
-               pxmitpriv->voq_cnt--;
-               break;
        case HIGH_QUEUE_INX:
                rtw_chk_hi_queue_cmd(padapter);
                break;
@@ -106,7 +103,6 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem)
 
        switch (addr) {
        case VO_QUEUE_INX:
-               pxmitpriv->voq_cnt++;
                pxmitbuf->flags = VO_QUEUE_INX;
                break;
        case VI_QUEUE_INX: