ARM: dts: imx7d-sdb: config the max pressure for tsc2046
authorHaibo Chen <haibo.chen@nxp.com>
Mon, 25 Jul 2022 10:16:22 +0000 (18:16 +0800)
committerShawn Guo <shawnguo@kernel.org>
Sun, 21 Aug 2022 08:38:31 +0000 (16:38 +0800)
Use the general touchscreen method to config the max pressure for
touch tsc2046(data sheet suggest 8 bit pressure), otherwise, for
ABS_PRESSURE, when config the same max and min value, weston will
meet the following issue,

[17:19:39.183] event1  - ADS7846 Touchscreen: is tagged by udev as: Touchscreen
[17:19:39.183] event1  - ADS7846 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE
[17:19:39.183] event1  - ADS7846 Touchscreen: was rejected
[17:19:39.183] event1  - not using input device '/dev/input/event1'

This will then cause the APP weston-touch-calibrator can't list touch devices.

root@imx6ul7d:~# weston-touch-calibrator
could not load cursor 'dnd-move'
could not load cursor 'dnd-copy'
could not load cursor 'dnd-none'
No devices listed.

And accroding to binding Doc, "ti,x-max", "ti,y-max", "ti,pressure-max"
belong to the deprecated properties, so remove them. Also for "ti,x-min",
"ti,y-min", "ti,x-plate-ohms", the value set in dts equal to the default
value in driver, so are redundant, also remove here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/boot/dts/imx7d-sdb.dts

index 78f4224a9bf4eb5795c34605ae186d5cbe52d7aa..e93b9cd9c27b2075339297e0371b3b50e0371046 100644 (file)
                interrupt-parent = <&gpio2>;
                interrupts = <29 0>;
                pendown-gpio = <&gpio2 29 GPIO_ACTIVE_HIGH>;
-               ti,x-min = /bits/ 16 <0>;
-               ti,x-max = /bits/ 16 <0>;
-               ti,y-min = /bits/ 16 <0>;
-               ti,y-max = /bits/ 16 <0>;
-               ti,pressure-max = /bits/ 16 <0>;
-               ti,x-plate-ohms = /bits/ 16 <400>;
+               touchscreen-max-pressure = <255>;
                wakeup-source;
        };
 };