media: cx231xx: Switch to use kmemdup() helper

Use kmemdup() helper instead of open-coding to
simplify the code.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/usb/cx231xx/cx231xx-core.c b/drivers/media/usb/cx231xx/cx231xx-core.c
index 727e6268567f757d553bcfefd17d8a99aa9ea4f4..746727ea1a4c7fa0020a7143e3d7c4ea0f35eafc 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-core.c
+++ b/drivers/media/usb/cx231xx/cx231xx-core.c
@@ -751,10 +751,9 @@ int cx231xx_ep5_bulkout(struct cx231xx *dev, u8 *firmware, u16 size)
        int ret = -ENOMEM;
        u32 *buffer;
 
-       buffer = kzalloc(4096, GFP_KERNEL);
+       buffer = kmemdup(firmware, 4096, GFP_KERNEL);
        if (buffer == NULL)
                return -ENOMEM;
-       memcpy(&buffer[0], firmware, 4096);
 
        ret = usb_bulk_msg(dev->udev, usb_sndbulkpipe(dev->udev, 5),
                        buffer, 4096, &actlen, 2000);