pinctrl: uniphier: Annotate struct uniphier_pinctrl_reg_region with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:50:06 +0000 (10:50 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 27 Sep 2023 08:59:06 +0000 (10:59 +0200)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct uniphier_pinctrl_reg_region.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175006.work.421-kees@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/uniphier/pinctrl-uniphier-core.c

index 18d3a4f69e639198b379fd6958b3f54256d3802b..fbd0fcdb42c8d72761da1211d478479b7788ee8d 100644 (file)
@@ -31,7 +31,7 @@ struct uniphier_pinctrl_reg_region {
        struct list_head node;
        unsigned int base;
        unsigned int nregs;
-       u32 vals[];
+       u32 vals[] __counted_by(nregs);
 };
 
 struct uniphier_pinctrl_priv {