USB: dummy-hcd: Fix uninitialized array use in init()
authorBui Quang Minh <minhquangbui99@gmail.com>
Fri, 4 Dec 2020 06:24:49 +0000 (06:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 Dec 2020 14:25:23 +0000 (15:25 +0100)
This error path

err_add_pdata:
for (i = 0; i < mod_data.num; i++)
kfree(dum[i]);

can be triggered when not all dum's elements are initialized.

Fix this by initializing all dum's elements to NULL.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
Link: https://lore.kernel.org/r/1607063090-3426-1-git-send-email-minhquangbui99@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/dummy_hcd.c

index f6b40777817989839ad74dcd39fa2ddb718983cd..ab5e978b5052c01e348a15e46bdfff9d493145aa 100644 (file)
@@ -2738,7 +2738,7 @@ static int __init init(void)
 {
        int     retval = -ENOMEM;
        int     i;
-       struct  dummy *dum[MAX_NUM_UDC];
+       struct  dummy *dum[MAX_NUM_UDC] = {};
 
        if (usb_disabled())
                return -ENODEV;