pinctrl: bcm: Simplify bool comparison
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Fri, 15 Jan 2021 10:09:09 +0000 (18:09 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 18 Jan 2021 15:30:08 +0000 (16:30 +0100)
Fix the follow coccicheck warnings:

./drivers/pinctrl/bcm/pinctrl-ns2-mux.c:856:29-38: WARNING:
Comparison to bool.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Link: https://lore.kernel.org/r/1610705349-24310-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/bcm/pinctrl-ns2-mux.c

index 57044ab376d3cf72954813bfe303ab7e0c8d644f..0fe4a1fcdf00744463d8fef2be3d09013b4d1ed0 100644 (file)
@@ -853,7 +853,7 @@ static int ns2_pin_config_get(struct pinctrl_dev *pctldev, unsigned int pin,
        switch (param) {
        case PIN_CONFIG_BIAS_DISABLE:
                ns2_pin_get_pull(pctldev, pin, &pull_up, &pull_down);
-               if ((pull_up == false) && (pull_down == false))
+               if (!pull_up && !pull_down)
                        return 0;
                else
                        return -EINVAL;