spi: mt7621: Fix an error message in mt7621_spi_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 27 Aug 2022 11:42:07 +0000 (13:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:34:40 +0000 (12:34 +0200)
[ Upstream commit 2b2bf6b7faa9010fae10dc7de76627a3fdb525b3 ]

'status' is known to be 0 at this point. The expected error code is
PTR_ERR(clk).

Switch to dev_err_probe() in order to display the expected error code (in a
human readable way).
This also filters -EPROBE_DEFER cases, should it happen.

Fixes: 1ab7f2a43558 ("staging: mt7621-spi: add mt7621 support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://lore.kernel.org/r/928f3fb507d53ba0774df27cea0bbba4b055993b.1661599671.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-mt7621.c

index b4b9b7309b5e949faf09aa129368a4c03da7aac2..351b0ef52bbc8d72cbaecce743d0ab3a2ff82f4a 100644 (file)
@@ -340,11 +340,9 @@ static int mt7621_spi_probe(struct platform_device *pdev)
                return PTR_ERR(base);
 
        clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(clk)) {
-               dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n",
-                       status);
-               return PTR_ERR(clk);
-       }
+       if (IS_ERR(clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(clk),
+                                    "unable to get SYS clock\n");
 
        status = clk_prepare_enable(clk);
        if (status)