media: dvb-frontends: tda18271c2dd: Remove casting during div
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 29 Apr 2024 15:04:47 +0000 (16:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 3 May 2024 10:08:08 +0000 (11:08 +0100)
do_div() divides 64 bits by 32. We were adding a casting to the divider
to 64 bits, for a number that fits perfectly in 32 bits. Remove it.

Found by cocci:
drivers/media/dvb-frontends/tda18271c2dd.c:355:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
drivers/media/dvb-frontends/tda18271c2dd.c:331:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-8-3c4865f5a4b0@chromium.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/dvb-frontends/tda18271c2dd.c

index a3483448794338a04c206dba5f5ba79b2d61198f..fd928787207edf63d351ebfc8f2bf9c6e482315c 100644 (file)
@@ -328,7 +328,7 @@ static int CalcMainPLL(struct tda_state *state, u32 freq)
 
        OscFreq = (u64) freq * (u64) Div;
        OscFreq *= (u64) 16384;
-       do_div(OscFreq, (u64)16000000);
+       do_div(OscFreq, 16000000);
        MainDiv = OscFreq;
 
        state->m_Regs[MPD] = PostDiv & 0x77;
@@ -352,7 +352,7 @@ static int CalcCalPLL(struct tda_state *state, u32 freq)
        OscFreq = (u64)freq * (u64)Div;
        /* CalDiv = u32( OscFreq * 16384 / 16000000 ); */
        OscFreq *= (u64)16384;
-       do_div(OscFreq, (u64)16000000);
+       do_div(OscFreq, 16000000);
        CalDiv = OscFreq;
 
        state->m_Regs[CPD] = PostDiv;