media: v4l2-ctrls.c: initialize flags field of p_fwht_params
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 12 Mar 2021 08:49:55 +0000 (09:49 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 10:56:09 +0000 (11:56 +0100)
The V4L2_CID_STATELESS_FWHT_PARAMS compound control was missing a
proper initialization of the flags field, so after loading the vicodec
module for the first time, running v4l2-compliance for the stateless
decoder would fail on this control because the initial control value
was considered invalid by the vicodec driver.

Initializing the flags field to sane values fixes this.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/v4l2-core/v4l2-ctrls.c

index 36a7983f720660e8e67cd28cfb261d318c77a70c..4ee301cc6e5b00389b354ebed79bc2414c1619f1 100644 (file)
@@ -1681,6 +1681,8 @@ static void std_init_compound(const struct v4l2_ctrl *ctrl, u32 idx,
                p_fwht_params->version = V4L2_FWHT_VERSION;
                p_fwht_params->width = 1280;
                p_fwht_params->height = 720;
+               p_fwht_params->flags = V4L2_FWHT_FL_PIXENC_YUV |
+                       (2 << V4L2_FWHT_FL_COMPONENTS_NUM_OFFSET);
                break;
        }
 }