power: supply: core: simplify power_supply_class_init
authorSebastian Reichel <sebastian.reichel@collabora.com>
Fri, 1 Mar 2024 22:58:27 +0000 (23:58 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 5 Mar 2024 23:21:34 +0000 (00:21 +0100)
Technically the sysfs attributes should be initialized
before the class is registered, since that will use them.
As a nice side effect this nicely simplifies the code,
since it allows dropping the helper variable.

Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net>
Link: https://lore.kernel.org/r/20240301-psy-class-cleanup-v1-2-aebe8c4b6b08@collabora.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/power_supply_core.c

index 0eb8a57dda70e1de243a3e8121eba73d2bf8fa55..4daea6ed8f1d0932fbe52bba1486fe4ddc8ea8f7 100644 (file)
@@ -1622,15 +1622,8 @@ EXPORT_SYMBOL_GPL(power_supply_get_drvdata);
 
 static int __init power_supply_class_init(void)
 {
-       int err;
-
-       err = class_register(&power_supply_class);
-       if (err)
-               return err;
-
        power_supply_init_attrs();
-
-       return 0;
+       return class_register(&power_supply_class);
 }
 
 static void __exit power_supply_class_exit(void)