media: dvb-core: dvb_frontend: address some clang warnings
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Nov 2021 08:59:53 +0000 (08:59 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 29 Nov 2021 09:15:04 +0000 (10:15 +0100)
The typecasts at the dvb-core generate clang warnings when W=1
is enabled.

The warns are harmless, but they cause the build to break with
CONFIG_WERROR, so do the cast on a way that it won't produce
warnings anymore.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-core/dvb_frontend.c

index 8fc59f3cfb6cdd30f5276bfc115a7fe8396733bf..48e735cdbe6bb2e08af5484bb802b4220861bafb 100644 (file)
@@ -2554,8 +2554,7 @@ static int dvb_frontend_handle_ioctl(struct file *file,
 
        case FE_DISEQC_SEND_BURST:
                if (fe->ops.diseqc_send_burst) {
-                       err = fe->ops.diseqc_send_burst(fe,
-                                               (enum fe_sec_mini_cmd)parg);
+                       err = fe->ops.diseqc_send_burst(fe, (long)parg);
                        fepriv->state = FESTATE_DISEQC;
                        fepriv->status = 0;
                }
@@ -2563,9 +2562,8 @@ static int dvb_frontend_handle_ioctl(struct file *file,
 
        case FE_SET_TONE:
                if (fe->ops.set_tone) {
-                       err = fe->ops.set_tone(fe,
-                                              (enum fe_sec_tone_mode)parg);
-                       fepriv->tone = (enum fe_sec_tone_mode)parg;
+                       fepriv->tone = (long)parg;
+                       err = fe->ops.set_tone(fe, fepriv->tone);
                        fepriv->state = FESTATE_DISEQC;
                        fepriv->status = 0;
                }
@@ -2573,9 +2571,8 @@ static int dvb_frontend_handle_ioctl(struct file *file,
 
        case FE_SET_VOLTAGE:
                if (fe->ops.set_voltage) {
-                       err = fe->ops.set_voltage(fe,
-                                                 (enum fe_sec_voltage)parg);
-                       fepriv->voltage = (enum fe_sec_voltage)parg;
+                       fepriv->voltage = (long)parg;
+                       err = fe->ops.set_voltage(fe, fepriv->voltage);
                        fepriv->state = FESTATE_DISEQC;
                        fepriv->status = 0;
                }