crypto: chtls - dereference null variable

skb dereferenced before check in sendpage

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Atul Gupta <atul.gupta@chelsio.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c
index 7aa5d90c6ebdbcfe7296020d7dd0a6c09f716059..8cfc27b4337df4a1133f943fc8ef9cfadf5a3153 100644 (file)
--- a/drivers/crypto/chelsio/chtls/chtls_io.c
+++ b/drivers/crypto/chelsio/chtls/chtls_io.c
@@ -1230,9 +1230,8 @@ int chtls_sendpage(struct sock *sk, struct page *page,
                struct sk_buff *skb = skb_peek_tail(&csk->txq);
                int copy, i;
 
-               copy = mss - skb->len;
                if (!skb || (ULP_SKB_CB(skb)->flags & ULPCB_FLAG_NO_APPEND) ||
-                   copy <= 0) {
+                   (copy = mss - skb->len) <= 0) {
 new_buf:
                        if (!csk_mem_free(cdev, sk))
                                goto wait_for_sndbuf;