RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps()
authorYuan Can <yuancan@huawei.com>
Sat, 26 Nov 2022 04:34:10 +0000 (04:34 +0000)
committerLeon Romanovsky <leon@kernel.org>
Mon, 28 Nov 2022 11:43:51 +0000 (13:43 +0200)
As the nla_nest_start() may fail with NULL returned, the return value needs
to be checked.

Fixes: c4ffee7c9bdb ("RDMA/netlink: Implement counter dumpit calback")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20221126043410.85632-1-yuancan@huawei.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/core/nldev.c

index 2be76a3fdd87ac69f0d5d2552cfe84b5ad9ef64f..ca0ed7d143261ca909658eb48bfb79df33c5c2fc 100644 (file)
@@ -894,6 +894,8 @@ static int fill_stat_counter_qps(struct sk_buff *msg,
        int ret = 0;
 
        table_attr = nla_nest_start(msg, RDMA_NLDEV_ATTR_RES_QP);
+       if (!table_attr)
+               return -EMSGSIZE;
 
        rt = &counter->device->res[RDMA_RESTRACK_QP];
        xa_lock(&rt->xa);