projects / linux.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: be7ef65)
clk: sprd: Add macros for referencing parents without strings
authorChunyan Zhang <chunyan.zhang@unisoc.com>
Wed, 4 Mar 2020 07:27:28 +0000 (15:27 +0800)
committerStephen Boyd <sboyd@kernel.org>
Wed, 25 Mar 2020 02:03:57 +0000 (19:03 -0700)
With the new clk parenting code, clk_init_data was expanded to include
.parent_hws and .parent_data, for clk drivers to specify parents without
name strings of clocks.

Also some macros were added for using these two items to reference
clock parents. Based on that to expand macros for sprd clocks:

- SPRD_*_DATA, take an array of struct clk_parent_data * as its parents
  which should be a combination of .fw_name (devicetree clock-names),
  .hw (pointers to a local struct clk_hw).

- SPRD_*_HW, take a local struct clk_hw pointer, instead of a string, as
  its parent.

- SPRD_*_FW_NAME, take a string of clock-names decleared in the device
  tree as the clock parent.

Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Link: https://lkml.kernel.org/r/20200304072730.9193-6-zhang.lyra@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/sprd/composite.h patch | blob | history
drivers/clk/sprd/div.h patch | blob | history
drivers/clk/sprd/gate.h patch | blob | history
drivers/clk/sprd/mux.h patch | blob | history
drivers/clk/sprd/pll.h patch | blob | history

diff --git a/drivers/clk/sprd/composite.h b/drivers/clk/sprd/composite.h
index 04ab3f587ee2b906fc6e43db6aa5ac152b91f208..adbabbe596b7018bc0c67f4d1c1d77639708fb1c 100644 (file)
--- a/drivers/clk/sprd/composite.h
+++ b/drivers/clk/sprd/composite.h
@@ -18,26 +18,43 @@ struct sprd_comp {
        struct sprd_clk_common  common;
 };
 
-#define SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, _table,     \
-                       _mshift, _mwidth, _dshift, _dwidth, _flags)     \
+#define SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table,        \
+                                _mshift, _mwidth, _dshift, _dwidth,    \
+                                _flags, _fn)                           \
        struct sprd_comp _struct = {                                    \
                .mux    = _SPRD_MUX_CLK(_mshift, _mwidth, _table),      \
                .div    = _SPRD_DIV_CLK(_dshift, _dwidth),              \
                .common = {                                             \
                        .regmap         = NULL,                         \
                        .reg            = _reg,                         \
-                       .hw.init = CLK_HW_INIT_PARENTS(_name,           \
-                                                      _parent,         \
-                                                      &sprd_comp_ops,  \
-                                                      _flags),         \
+                       .hw.init = _fn(_name, _parent,                  \
+                                      &sprd_comp_ops, _flags),         \
                         }                                              \
        }
 
-#define SPRD_COMP_CLK(_struct, _name, _parent, _reg, _mshift,  \
-                       _mwidth, _dshift, _dwidth, _flags)      \
-       SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg,      \
-                           NULL, _mshift, _mwidth,             \
-                           _dshift, _dwidth, _flags)
+#define SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, _table,     \
+                           _mshift, _mwidth, _dshift, _dwidth, _flags) \
+       SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table, \
+                                _mshift, _mwidth, _dshift, _dwidth,    \
+                                _flags, CLK_HW_INIT_PARENTS)
+
+#define SPRD_COMP_CLK(_struct, _name, _parent, _reg, _mshift,          \
+                     _mwidth, _dshift, _dwidth, _flags)                \
+       SPRD_COMP_CLK_TABLE(_struct, _name, _parent, _reg, NULL,        \
+                           _mshift, _mwidth, _dshift, _dwidth, _flags)
+
+#define SPRD_COMP_CLK_DATA_TABLE(_struct, _name, _parent, _reg, _table,        \
+                                _mshift, _mwidth, _dshift,             \
+                                _dwidth, _flags)                       \
+       SPRD_COMP_CLK_HW_INIT_FN(_struct, _name, _parent, _reg, _table, \
+                                _mshift, _mwidth, _dshift, _dwidth,    \
+                                _flags, CLK_HW_INIT_PARENTS_DATA)
+
+#define SPRD_COMP_CLK_DATA(_struct, _name, _parent, _reg, _mshift,     \
+                          _mwidth, _dshift, _dwidth, _flags)           \
+       SPRD_COMP_CLK_DATA_TABLE(_struct, _name, _parent, _reg, NULL,   \
+                                _mshift, _mwidth, _dshift, _dwidth,    \
+                                _flags)
 
 static inline struct sprd_comp *hw_to_sprd_comp(const struct clk_hw *hw)
 {
diff --git a/drivers/clk/sprd/div.h b/drivers/clk/sprd/div.h
index 87510e3d0e14ab7c29349017fac3b5c1396d8f96..6acfe6b179fc20113e3f8ed5bd3fcc17a7f00384 100644 (file)
--- a/drivers/clk/sprd/div.h
+++ b/drivers/clk/sprd/div.h
@@ -35,20 +35,28 @@ struct sprd_div {
        struct sprd_clk_common  common;
 };
 
-#define SPRD_DIV_CLK(_struct, _name, _parent, _reg,                    \
-                       _shift, _width, _flags)                         \
+#define SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,         \
+                               _shift, _width, _flags, _fn)            \
        struct sprd_div _struct = {                                     \
                .div    = _SPRD_DIV_CLK(_shift, _width),                \
                .common = {                                             \
                        .regmap         = NULL,                         \
                        .reg            = _reg,                         \
-                       .hw.init        = CLK_HW_INIT(_name,            \
-                                                     _parent,          \
-                                                     &sprd_div_ops,    \
-                                                     _flags),          \
+                       .hw.init        = _fn(_name, _parent,           \
+                                             &sprd_div_ops, _flags),   \
                }                                                       \
        }
 
+#define SPRD_DIV_CLK(_struct, _name, _parent, _reg,                    \
+                    _shift, _width, _flags)                            \
+       SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,          \
+                               _shift, _width, _flags, CLK_HW_INIT)
+
+#define SPRD_DIV_CLK_HW(_struct, _name, _parent, _reg,                 \
+                       _shift, _width, _flags)                         \
+       SPRD_DIV_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,          \
+                               _shift, _width, _flags, CLK_HW_INIT_HW)
+
 static inline struct sprd_div *hw_to_sprd_div(const struct clk_hw *hw)
 {
        struct sprd_clk_common *common = hw_to_sprd_clk_common(hw);
diff --git a/drivers/clk/sprd/gate.h b/drivers/clk/sprd/gate.h
index d380d77b8dce65e9c5593442fe5f9095d22fdc51..b55817869367fe87694bf75ba8b73326bb13d15d 100644 (file)
--- a/drivers/clk/sprd/gate.h
+++ b/drivers/clk/sprd/gate.h
@@ -19,9 +19,9 @@ struct sprd_gate {
        struct sprd_clk_common  common;
 };
 
-#define SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg,     \
+#define SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,     \
                                    _sc_offset, _enable_mask, _flags,   \
-                                   _gate_flags, _udelay, _ops)         \
+                                   _gate_flags, _udelay, _ops, _fn)    \
        struct sprd_gate _struct = {                                    \
                .enable_mask    = _enable_mask,                         \
                .sc_offset      = _sc_offset,                           \
@@ -30,38 +30,121 @@ struct sprd_gate {
                .common = {                                             \
                        .regmap         = NULL,                         \
                        .reg            = _reg,                         \
-                       .hw.init        = CLK_HW_INIT(_name,            \
-                                                     _parent,          \
-                                                     _ops,             \
-                                                     _flags),          \
+                       .hw.init        = _fn(_name, _parent,           \
+                                             _ops, _flags),            \
                }                                                       \
        }
 
+#define SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg,     \
+                                   _sc_offset, _enable_mask, _flags,   \
+                                   _gate_flags, _udelay, _ops)         \
+       SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,      \
+                                   _sc_offset, _enable_mask, _flags,   \
+                                   _gate_flags, _udelay, _ops, CLK_HW_INIT)
+
 #define SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, _sc_offset,        \
                             _enable_mask, _flags, _gate_flags, _ops)   \
        SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg,      \
                                    _sc_offset, _enable_mask, _flags,   \
                                    _gate_flags, 0, _ops)
 
-#define SPRD_GATE_CLK(_struct, _name, _parent, _reg,                   \
-                     _enable_mask, _flags, _gate_flags)                \
-       SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, 0,          \
-                            _enable_mask, _flags, _gate_flags,         \
-                            &sprd_gate_ops)
-
 #define SPRD_SC_GATE_CLK(_struct, _name, _parent, _reg, _sc_offset,    \
                         _enable_mask, _flags, _gate_flags)             \
        SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, _sc_offset, \
                             _enable_mask, _flags, _gate_flags,         \
                             &sprd_sc_gate_ops)
 
+#define SPRD_GATE_CLK(_struct, _name, _parent, _reg,                   \
+                     _enable_mask, _flags, _gate_flags)                \
+       SPRD_SC_GATE_CLK_OPS(_struct, _name, _parent, _reg, 0,          \
+                            _enable_mask, _flags, _gate_flags,         \
+                            &sprd_gate_ops)
+
 #define SPRD_PLL_SC_GATE_CLK(_struct, _name, _parent, _reg, _sc_offset,        \
-                           _enable_mask, _flags, _gate_flags, _udelay) \
+                            _enable_mask, _flags, _gate_flags,         \
+                            _udelay)                                   \
        SPRD_SC_GATE_CLK_OPS_UDELAY(_struct, _name, _parent, _reg,      \
                                    _sc_offset, _enable_mask, _flags,   \
                                    _gate_flags, _udelay,               \
                                    &sprd_pll_sc_gate_ops)
 
+
+#define SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg,  \
+                                      _sc_offset, _enable_mask,        \
+                                      _flags, _gate_flags,             \
+                                      _udelay, _ops)                   \
+       SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,      \
+                                   _sc_offset, _enable_mask, _flags,   \
+                                   _gate_flags, _udelay, _ops,         \
+                                   CLK_HW_INIT_HW)
+
+#define SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg,         \
+                               _sc_offset, _enable_mask, _flags,       \
+                               _gate_flags, _ops)                      \
+       SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg,   \
+                                      _sc_offset, _enable_mask,        \
+                                      _flags, _gate_flags, 0, _ops)
+
+#define SPRD_SC_GATE_CLK_HW(_struct, _name, _parent, _reg,             \
+                           _sc_offset, _enable_mask, _flags,           \
+                           _gate_flags)                                \
+       SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg,          \
+                               _sc_offset, _enable_mask, _flags,       \
+                               _gate_flags, &sprd_sc_gate_ops)
+
+#define SPRD_GATE_CLK_HW(_struct, _name, _parent, _reg,                        \
+                        _enable_mask, _flags, _gate_flags)             \
+       SPRD_SC_GATE_CLK_HW_OPS(_struct, _name, _parent, _reg, 0,       \
+                               _enable_mask, _flags, _gate_flags,      \
+                               &sprd_gate_ops)
+
+#define SPRD_PLL_SC_GATE_CLK_HW(_struct, _name, _parent, _reg,         \
+                               _sc_offset, _enable_mask, _flags,       \
+                               _gate_flags, _udelay)                   \
+       SPRD_SC_GATE_CLK_HW_OPS_UDELAY(_struct, _name, _parent, _reg,   \
+                                      _sc_offset, _enable_mask,        \
+                                      _flags, _gate_flags, _udelay,    \
+                                      &sprd_pll_sc_gate_ops)
+
+#define SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent,   \
+                                           _reg, _sc_offset,           \
+                                           _enable_mask, _flags,       \
+                                           _gate_flags, _udelay, _ops) \
+       SPRD_SC_GATE_CLK_HW_INIT_FN(_struct, _name, _parent, _reg,      \
+                                   _sc_offset, _enable_mask, _flags,   \
+                                   _gate_flags, _udelay, _ops,         \
+                                   CLK_HW_INIT_FW_NAME)
+
+#define SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg,    \
+                                    _sc_offset, _enable_mask, _flags,  \
+                                    _gate_flags, _ops)                 \
+       SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent,    \
+                                           _reg, _sc_offset,           \
+                                           _enable_mask, _flags,       \
+                                           _gate_flags, 0, _ops)
+
+#define SPRD_SC_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg,                \
+                                _sc_offset, _enable_mask, _flags,      \
+                                _gate_flags)                           \
+       SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg,     \
+                                    _sc_offset, _enable_mask, _flags,  \
+                                    _gate_flags, &sprd_sc_gate_ops)
+
+#define SPRD_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg,           \
+                             _enable_mask, _flags, _gate_flags)        \
+       SPRD_SC_GATE_CLK_FW_NAME_OPS(_struct, _name, _parent, _reg, 0,  \
+                                    _enable_mask, _flags, _gate_flags, \
+                                    &sprd_gate_ops)
+
+#define SPRD_PLL_SC_GATE_CLK_FW_NAME(_struct, _name, _parent, _reg,    \
+                                    _sc_offset, _enable_mask, _flags,  \
+                                    _gate_flags, _udelay)              \
+       SPRD_SC_GATE_CLK_FW_NAME_OPS_UDELAY(_struct, _name, _parent,    \
+                                           _reg, _sc_offset,           \
+                                           _enable_mask, _flags,       \
+                                           _gate_flags, _udelay,       \
+                                           &sprd_pll_sc_gate_ops)
+
 static inline struct sprd_gate *hw_to_sprd_gate(const struct clk_hw *hw)
 {
        struct sprd_clk_common *common = hw_to_sprd_clk_common(hw);
diff --git a/drivers/clk/sprd/mux.h b/drivers/clk/sprd/mux.h
index 892e4191cc7f12f364ada9f95ecfc5cb97a5d406..f3cc31dae06f8b857aacbb133c92fe5b891e0105 100644 (file)
--- a/drivers/clk/sprd/mux.h
+++ b/drivers/clk/sprd/mux.h
@@ -36,26 +36,40 @@ struct sprd_mux {
                .table  = _table,                       \
        }
 
-#define SPRD_MUX_CLK_TABLE(_struct, _name, _parents, _table,           \
-                                    _reg, _shift, _width,              \
-                                    _flags)                            \
+#define SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table,      \
+                               _reg, _shift, _width, _flags, _fn)      \
        struct sprd_mux _struct = {                                     \
                .mux    = _SPRD_MUX_CLK(_shift, _width, _table),        \
                .common = {                                             \
                        .regmap         = NULL,                         \
                        .reg            = _reg,                         \
-                       .hw.init = CLK_HW_INIT_PARENTS(_name,           \
-                                                      _parents,        \
-                                                      &sprd_mux_ops,   \
-                                                      _flags),         \
+                       .hw.init = _fn(_name, _parents,                 \
+                                      &sprd_mux_ops, _flags),          \
                }                                                       \
        }
 
+#define SPRD_MUX_CLK_TABLE(_struct, _name, _parents, _table,           \
+                          _reg, _shift, _width, _flags)                \
+       SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table,       \
+                               _reg, _shift, _width, _flags,           \
+                               CLK_HW_INIT_PARENTS)
+
 #define SPRD_MUX_CLK(_struct, _name, _parents, _reg,           \
                     _shift, _width, _flags)                    \
        SPRD_MUX_CLK_TABLE(_struct, _name, _parents, NULL,      \
                           _reg, _shift, _width, _flags)
 
+#define SPRD_MUX_CLK_DATA_TABLE(_struct, _name, _parents, _table,      \
+                               _reg, _shift, _width, _flags)           \
+       SPRD_MUX_CLK_HW_INIT_FN(_struct, _name, _parents, _table,       \
+                               _reg, _shift, _width, _flags,           \
+                               CLK_HW_INIT_PARENTS_DATA)
+
+#define SPRD_MUX_CLK_DATA(_struct, _name, _parents, _reg,              \
+                         _shift, _width, _flags)                       \
+       SPRD_MUX_CLK_DATA_TABLE(_struct, _name, _parents, NULL,         \
+                               _reg, _shift, _width, _flags)
+
 static inline struct sprd_mux *hw_to_sprd_mux(const struct clk_hw *hw)
 {
        struct sprd_clk_common *common = hw_to_sprd_clk_common(hw);
diff --git a/drivers/clk/sprd/pll.h b/drivers/clk/sprd/pll.h
index e95f11e91ffe15f3bddecf5428880d406e2c077e..6558f50d0296bc2acd43b031e3927c288434fc08 100644 (file)
--- a/drivers/clk/sprd/pll.h
+++ b/drivers/clk/sprd/pll.h
@@ -61,27 +61,33 @@ struct sprd_pll {
        struct sprd_clk_common  common;
 };
 
+#define SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg,     \
+                           _regs_num, _itable, _factors,       \
+                           _udelay, _k1, _k2, _fflag,          \
+                           _fvco, _fn)                         \
+       struct sprd_pll _struct = {                             \
+               .regs_num       = _regs_num,                    \
+               .itable         = _itable,                      \
+               .factors        = _factors,                     \
+               .udelay         = _udelay,                      \
+               .k1             = _k1,                          \
+               .k2             = _k2,                          \
+               .fflag          = _fflag,                       \
+               .fvco           = _fvco,                        \
+               .common         = {                             \
+                       .regmap         = NULL,                 \
+                       .reg            = _reg,                 \
+                       .hw.init        = _fn(_name, _parent,   \
+                                             &sprd_pll_ops, 0),\
+               },                                              \
+       }
+
 #define SPRD_PLL_WITH_ITABLE_K_FVCO(_struct, _name, _parent, _reg,     \
                                    _regs_num, _itable, _factors,       \
                                    _udelay, _k1, _k2, _fflag, _fvco)   \
-       struct sprd_pll _struct = {                                     \
-               .regs_num       = _regs_num,                            \
-               .itable         = _itable,                              \
-               .factors        = _factors,                             \
-               .udelay         = _udelay,                              \
-               .k1             = _k1,                                  \
-               .k2             = _k2,                                  \
-               .fflag          = _fflag,                               \
-               .fvco           = _fvco,                                \
-               .common         = {                                     \
-                       .regmap         = NULL,                         \
-                       .reg            = _reg,                         \
-                       .hw.init        = CLK_HW_INIT(_name,            \
-                                                     _parent,          \
-                                                     &sprd_pll_ops,    \
-                                                     0),               \
-               },                                                      \
-       }
+       SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num,   \
+                           _itable, _factors, _udelay, _k1, _k2,       \
+                           _fflag, _fvco, CLK_HW_INIT)
 
 #define SPRD_PLL_WITH_ITABLE_K(_struct, _name, _parent, _reg,          \
                               _regs_num, _itable, _factors,            \
@@ -96,6 +102,19 @@ struct sprd_pll {
                                    _regs_num, _itable, _factors,       \
                                    _udelay, 1000, 1000, 0, 0)
 
+#define SPRD_PLL_FW_NAME(_struct, _name, _parent, _reg, _regs_num,     \
+                        _itable, _factors, _udelay, _k1, _k2,          \
+                        _fflag, _fvco)                                 \
+       SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num,   \
+                           _itable, _factors, _udelay, _k1, _k2,       \
+                           _fflag, _fvco, CLK_HW_INIT_FW_NAME)
+
+#define SPRD_PLL_HW(_struct, _name, _parent, _reg, _regs_num, _itable, \
+                   _factors, _udelay, _k1, _k2, _fflag, _fvco)         \
+       SPRD_PLL_HW_INIT_FN(_struct, _name, _parent, _reg, _regs_num,   \
+                           _itable, _factors, _udelay, _k1, _k2,       \
+                           _fflag, _fvco, CLK_HW_INIT_HW)
+
 static inline struct sprd_pll *hw_to_sprd_pll(struct clk_hw *hw)
 {
        struct sprd_clk_common *common = hw_to_sprd_clk_common(hw);
ep93xx device tree rework repo: git://git.maquefel.me/linux.git