media: i2c: ds90ub913: Fix use of uninitialized variables
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Thu, 3 Aug 2023 12:15:45 +0000 (14:15 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 14 Aug 2023 18:27:58 +0000 (20:27 +0200)
smatch reports some uninitialized variables:

drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'.
drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'.

These are used only for printing debug information, and the use of an
uninitialized variable only happens if an i2c transaction has failed,
which will print an error. Thus, fix the errors just by initializing the
variables to 0.

Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/
Fixes: c158d0d4ff15 ("media: i2c: add DS90UB913 driver")
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ds90ub913.c

index 85b664e33482ea98d946131c3a2b90226fdda962..4bfa3b3cf619b36e0f3eb7bef9813fe8082cecb9 100644 (file)
@@ -471,7 +471,7 @@ static int ub913_log_status(struct v4l2_subdev *sd)
 {
        struct ub913_data *priv = sd_to_ub913(sd);
        struct device *dev = &priv->client->dev;
-       u8 v = 0, v1, v2;
+       u8 v = 0, v1 = 0, v2 = 0;
 
        ub913_read(priv, UB913_REG_MODE_SEL, &v);
        dev_info(dev, "MODE_SEL %#02x\n", v);