crypto: aspeed - fix type warnings

This patch fixes following warnings:

1. sparse: incorrect type in assignment (different base types)
Fix: change to __le32 type.
2. sparse: cast removes address space '__iomem' of expression
Fix: use readb to avoid dereferencing the memory.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c
index 164c524015f0dbd012e5e483d206fefcb815cce7..1f77ebd7348926ec04b057c348677b859d52c141 100644 (file)
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -252,7 +252,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf,
                                    enum aspeed_rsa_key_mode mode)
 {
        const u8 *src = xbuf;
-       u32 *dw_buf = (u32 *)buf;
+       __le32 *dw_buf = buf;
        int nbits, ndw;
        int i, j, idx;
        u32 data = 0;
@@ -302,7 +302,7 @@ static int aspeed_acry_rsa_ctx_copy(struct aspeed_acry_dev *acry_dev, void *buf,
 static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
 {
        struct akcipher_request *req = acry_dev->req;
-       u8 *sram_buffer = (u8 *)acry_dev->acry_sram;
+       u8 __iomem *sram_buffer = acry_dev->acry_sram;
        struct scatterlist *out_sg = req->dst;
        static u8 dram_buffer[ASPEED_ACRY_SRAM_MAX_LEN];
        int leading_zero = 1;
@@ -321,11 +321,11 @@ static int aspeed_acry_rsa_transfer(struct aspeed_acry_dev *acry_dev)
 
        for (j = ASPEED_ACRY_SRAM_MAX_LEN - 1; j >= 0; j--) {
                data_idx = acry_dev->data_byte_mapping[j];
-               if (sram_buffer[data_idx] == 0 && leading_zero) {
+               if (readb(sram_buffer + data_idx) == 0 && leading_zero) {
                        result_nbytes--;
                } else {
                        leading_zero = 0;
-                       dram_buffer[i] = sram_buffer[data_idx];
+                       dram_buffer[i] = readb(sram_buffer + data_idx);
                        i++;
                }
        }