HID: i2c-hid: goodix: Add mainboard-vddio-supply
authorDouglas Anderson <dianders@chromium.org>
Tue, 7 Feb 2023 02:48:15 +0000 (18:48 -0800)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Thu, 9 Feb 2023 13:44:15 +0000 (14:44 +0100)
As talked about in the patch ("dt-bindings: HID: i2c-hid: goodix: Add
mainboard-vddio-supply") we may need to power up a 1.8V rail on the
host associated with touchscreen IO. Let's add support in the driver
for it.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Link: https://lore.kernel.org/r/20230206184744.6.Ic234b931025d1f920ce9e06fff294643943a65ad@changeid
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/i2c-hid/i2c-hid-of-goodix.c

index 584d833dc0aaa3bd30d753170120622b0849ab39..0060e3dcd775d8fe081c7df4ecf34d3ff557bf20 100644 (file)
@@ -26,6 +26,7 @@ struct i2c_hid_of_goodix {
        struct i2chid_ops ops;
 
        struct regulator *vdd;
+       struct regulator *vddio;
        struct gpio_desc *reset_gpio;
        const struct goodix_i2c_hid_timing_data *timings;
 };
@@ -40,6 +41,10 @@ static int goodix_i2c_hid_power_up(struct i2chid_ops *ops)
        if (ret)
                return ret;
 
+       ret = regulator_enable(ihid_goodix->vddio);
+       if (ret)
+               return ret;
+
        if (ihid_goodix->timings->post_power_delay_ms)
                msleep(ihid_goodix->timings->post_power_delay_ms);
 
@@ -56,6 +61,7 @@ static void goodix_i2c_hid_power_down(struct i2chid_ops *ops)
                container_of(ops, struct i2c_hid_of_goodix, ops);
 
        gpiod_set_value_cansleep(ihid_goodix->reset_gpio, 1);
+       regulator_disable(ihid_goodix->vddio);
        regulator_disable(ihid_goodix->vdd);
 }
 
@@ -81,6 +87,10 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client)
        if (IS_ERR(ihid_goodix->vdd))
                return PTR_ERR(ihid_goodix->vdd);
 
+       ihid_goodix->vddio = devm_regulator_get(&client->dev, "mainboard-vddio");
+       if (IS_ERR(ihid_goodix->vddio))
+               return PTR_ERR(ihid_goodix->vddio);
+
        ihid_goodix->timings = device_get_match_data(&client->dev);
 
        return i2c_hid_core_probe(client, &ihid_goodix->ops, 0x0001, 0);