virtio_net: Reuse buffer free function
authorParav Pandit <parav@nvidia.com>
Mon, 16 Jan 2023 20:27:08 +0000 (22:27 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Jan 2023 13:51:48 +0000 (13:51 +0000)
virtnet_rq_free_unused_buf() helper function to free the buffer
already exists. Avoid code duplication by reusing existing function.

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c

index 68804528f12933d652e3dfb5f9caf9443cdf89b2..c0e59d660600bfed70d01c36caeae65bb7c3f067 100644 (file)
@@ -1375,13 +1375,7 @@ static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq,
        if (unlikely(len < vi->hdr_len + ETH_HLEN)) {
                pr_debug("%s: short packet %i\n", dev->name, len);
                dev->stats.rx_length_errors++;
-               if (vi->mergeable_rx_bufs) {
-                       put_page(virt_to_head_page(buf));
-               } else if (vi->big_packets) {
-                       give_pages(rq, buf);
-               } else {
-                       put_page(virt_to_head_page(buf));
-               }
+               virtnet_rq_free_unused_buf(rq->vq, buf);
                return;
        }