gpioset: fix a segfault with default mode

The default mode (exit) doesn't have a callback so we need to check if
the callback funtion pointer isn't NULL.

Fixes: 9b6e6d268671 ("ctxless: drop all context-less interfaces")
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
index b35a36e763d9a98b09c80b65f03a4b997b3afc6f..a5b97e1f98eecbe2cc35c7e8a0c94f36703b7283 100755 (executable)
--- a/tools/gpio-tools-test.bats
+++ b/tools/gpio-tools-test.bats
@@ -599,6 +599,14 @@ teardown() {
        output_regex_match ".*can't specify wait time in this mode"
 }
 
+@test "gpioset: default mode" {
+       gpio_mockup_probe 8 8 8
+
+       run_tool gpioset "$(gpio_mockup_chip_name 1)" 0=1
+
+       test "$status" -eq "0"
+}
+
 @test "gpioset: invalid mapping" {
        gpio_mockup_probe 8 8 8
 

diff --git a/tools/gpioset.c b/tools/gpioset.c
index a088ec6416abd073f434b64e143ce2326aa98d95..7882b53bab4177573d5864cd2ebf9c13f6592989 100644 (file)
--- a/tools/gpioset.c
+++ b/tools/gpioset.c
@@ -302,7 +302,8 @@ int main(int argc, char **argv)
        if (rv)
                die_perror("unable to request lines");
 
-       mode->callback(&cbdata);
+       if (mode->callback)
+               mode->callback(&cbdata);
 
        gpiod_line_release_bulk(lines);
        gpiod_chip_unref(chip);