perf annotate-data: Skip sample histogram for stack canary
authorNamhyung Kim <namhyung@kernel.org>
Thu, 11 Apr 2024 03:32:50 +0000 (20:32 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 12 Apr 2024 15:02:06 +0000 (12:02 -0300)
It's a pseudo data type and has no field.

Fixes: b3c95109c131fcc9 ("perf annotate-data: Add stack canary type")
Closes: https://lore.kernel.org/lkml/Zhb6jJneP36Z-or0@x1
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240411033256.2099646-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c

index 11da27801d8834ab81ca4745def62e65cf9f9d2e..ec79c120a7d2f3840b21da4b1a6f634bf8e60b0e 100644 (file)
@@ -2399,8 +2399,9 @@ retry:
                mem_type = find_data_type(&dloc);
 
                if (mem_type == NULL && is_stack_canary(arch, op_loc)) {
-                       mem_type = &canary_type;
-                       dloc.type_offset = 0;
+                       istat->good++;
+                       he->mem_type_off = 0;
+                       return &canary_type;
                }
 
                if (mem_type)