usb: chipidea: tegra: Consistently use dev_err_probe()
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Thu, 28 Sep 2023 21:06:04 +0000 (23:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Oct 2023 12:10:47 +0000 (14:10 +0200)
Convert all error exits from probe() to dev_err_probe().

Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/43d03aad1c394d9995f69d13ca1176f9ff8a8dab.1695934946.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci_hdrc_tegra.c

index 8e78bf643e25c3c90fe853be7d3dd56867d12cee..2cc305803217d8010d5543a56df2310de60c187e 100644 (file)
@@ -293,14 +293,12 @@ static int tegra_usb_probe(struct platform_device *pdev)
        usb->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "nvidia,phy", 0);
        if (IS_ERR(usb->phy))
                return dev_err_probe(&pdev->dev, PTR_ERR(usb->phy),
-                                    "failed to get PHY\n");
+                                    "failed to get PHY");
 
        usb->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(usb->clk)) {
-               err = PTR_ERR(usb->clk);
-               dev_err(&pdev->dev, "failed to get clock: %d\n", err);
-               return err;
-       }
+       if (IS_ERR(usb->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(usb->clk),
+                                    "failed to get clock");
 
        err = devm_tegra_core_dev_init_opp_table_common(&pdev->dev);
        if (err)
@@ -316,7 +314,7 @@ static int tegra_usb_probe(struct platform_device *pdev)
 
        err = tegra_usb_reset_controller(&pdev->dev);
        if (err) {
-               dev_err(&pdev->dev, "failed to reset controller: %d\n", err);
+               dev_err_probe(&pdev->dev, err, "failed to reset controller");
                goto fail_power_off;
        }
 
@@ -347,8 +345,8 @@ static int tegra_usb_probe(struct platform_device *pdev)
        usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
                                      pdev->num_resources, &usb->data);
        if (IS_ERR(usb->dev)) {
-               err = PTR_ERR(usb->dev);
-               dev_err(&pdev->dev, "failed to add HDRC device: %d\n", err);
+               err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev),
+                                   "failed to add HDRC device");
                goto phy_shutdown;
        }