drm/bridge: tc358767: Simplify polling in tc_main_link_setup()

Replace explicit polling loop with equivalent call to
tc_poll_timeout() for brevity. No functional change intended.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Cory Tusar <cory.tusar@zii.aero>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190619052716.16831-3-andrew.smirnov@gmail.com

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 684944f8e86656d5b6c5695abdd4192ba8092752..109085c2660e5e2c8ee4911d72bb0436b9865151 100644 (file)
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -765,7 +765,6 @@ static int tc_main_link_enable(struct tc_data *tc)
        struct device *dev = tc->dev;
        unsigned int rate;
        u32 dp_phy_ctrl;
-       int timeout;
        u32 value;
        int ret;
        u8 tmp[8];
@@ -822,15 +821,10 @@ static int tc_main_link_enable(struct tc_data *tc)
        dp_phy_ctrl &= ~(DP_PHY_RST | PHY_M1_RST | PHY_M0_RST);
        tc_write(DP_PHY_CTRL, dp_phy_ctrl);
 
-       timeout = 1000;
-       do {
-               tc_read(DP_PHY_CTRL, &value);
-               udelay(1);
-       } while ((!(value & PHY_RDY)) && (--timeout));
-
-       if (timeout == 0) {
+       ret = tc_poll_timeout(tc, DP_PHY_CTRL, PHY_RDY, PHY_RDY, 1, 1000);
+       if (ret) {
                dev_err(dev, "timeout waiting for phy become ready");
-               return -ETIMEDOUT;
+               return ret;
        }
 
        /* Set misc: 8 bits per color */