dmaengine: fsl-dpaa2-qdma: Add dpdmai_cmd_open
authorFrank Li <Frank.Li@nxp.com>
Wed, 20 Mar 2024 19:39:21 +0000 (15:39 -0400)
committerVinod Koul <vkoul@kernel.org>
Sun, 7 Apr 2024 12:22:59 +0000 (17:52 +0530)
Introduce the structures dpdmai_cmd_open to maintain consistency within the
API calls of the driver.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240320-dpaa2-v1-3-eb56e47c94ec@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-dpaa2-qdma/dpdmai.c

index 66a3953f0e3b126012a591d03d87d34a7d0920d1..610f6231835a816300c700ab19f753ed0edbe251 100644 (file)
@@ -33,6 +33,10 @@ struct dpdmai_rsp_get_tx_queue {
        __le32 fqid;
 };
 
+struct dpdmai_cmd_open {
+       __le32 dpdmai_id;
+} __packed;
+
 static inline u64 mc_enc(int lsoffset, int width, u64 val)
 {
        return (val & MAKE_UMASK64(width)) << lsoffset;
@@ -58,16 +62,16 @@ static inline u64 mc_enc(int lsoffset, int width, u64 val)
 int dpdmai_open(struct fsl_mc_io *mc_io, u32 cmd_flags,
                int dpdmai_id, u16 *token)
 {
+       struct dpdmai_cmd_open *cmd_params;
        struct fsl_mc_command cmd = { 0 };
-       __le64 *cmd_dpdmai_id;
        int err;
 
        /* prepare command */
        cmd.header = mc_encode_cmd_header(DPDMAI_CMDID_OPEN,
                                          cmd_flags, 0);
 
-       cmd_dpdmai_id = cmd.params;
-       *cmd_dpdmai_id = cpu_to_le32(dpdmai_id);
+       cmd_params = (struct dpdmai_cmd_open *)&cmd.params;
+       cmd_params->dpdmai_id = cpu_to_le32(dpdmai_id);
 
        /* send command to mc*/
        err = mc_send_command(mc_io, &cmd);