]> git.maquefel.me Git - brevno-suite/hugo/commitdiff
tpl/tplimpl: Update Google Analytics template and config
authorJoe Mooring <joe.mooring@veriphor.com>
Sat, 23 Mar 2024 20:07:00 +0000 (13:07 -0700)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Tue, 26 Mar 2024 14:40:51 +0000 (15:40 +0100)
Google Analytics 4 (GA4) replaced Google Universal Analytics (UA)
effective 1 July 2023.

See https://support.google.com/analytics/answer/11583528.

Changes:

- Update tpl/tplimpl/embedded/templates/google_analytics.html
- Remove tpl/tplimpl/embedded/templates/google_analytics_async.html
- Remove extraneous config settings

Closes #11802
Closes #10093

config/privacy/privacyConfig.go
config/privacy/privacyConfig_test.go
docs/data/docs.yaml
hugolib/embedded_templates_test.go
hugolib/testhelpers_test.go
tpl/tplimpl/embedded/templates/google_analytics.html
tpl/tplimpl/embedded/templates/google_analytics_async.html [deleted file]
tpl/tplimpl/tplimpl_integration_test.go

index a360463643f39a2370d807f89011744e5c7af91b..8880b1036d6865ff4a6777f4672481a8dde9be5a 100644 (file)
@@ -44,15 +44,9 @@ type Disqus struct {
 type GoogleAnalytics struct {
        Service `mapstructure:",squash"`
 
-       // Enabling this will disable the use of Cookies and use Session Storage to Store the GA Client ID.
-       UseSessionStorage bool
-
        // Enabling this will make the GA templates respect the
        // "Do Not Track" HTTP header. See  https://www.paulfurley.com/google-analytics-dnt/.
        RespectDoNotTrack bool
-
-       // Enabling this will make it so the users' IP addresses are anonymized within Google Analytics.
-       AnonymizeIP bool
 }
 
 // Instagram holds the privacy configuration settings related to the Instagram shortcode.
index c17ce713deae16abd550a5efb1ae5938889ac7ca..bff627f48e10c7d37594599a49af6512e7111b55 100644 (file)
@@ -33,8 +33,6 @@ disable = true
 [privacy.googleAnalytics]
 disable = true
 respectDoNotTrack = true
-anonymizeIP = true
-useSessionStorage = true
 [privacy.instagram]
 disable = true
 simple = true
@@ -60,8 +58,7 @@ simple = true
 
        got := []bool{
                pc.Disqus.Disable, pc.GoogleAnalytics.Disable,
-               pc.GoogleAnalytics.RespectDoNotTrack, pc.GoogleAnalytics.AnonymizeIP,
-               pc.GoogleAnalytics.UseSessionStorage, pc.Instagram.Disable,
+               pc.GoogleAnalytics.RespectDoNotTrack, pc.Instagram.Disable,
                pc.Instagram.Simple, pc.Twitter.Disable, pc.Twitter.EnableDNT,
                pc.Twitter.Simple, pc.Vimeo.Disable, pc.Vimeo.EnableDNT, pc.Vimeo.Simple,
                pc.YouTube.PrivacyEnhanced, pc.YouTube.Disable,
index ad47ac54d287e77f67c04a1d6f129c4394c9a610..f9b5731f2b6cf5a048e2027bde068b096c3b5c3c 100644 (file)
@@ -1557,10 +1557,8 @@ config:
     disqus:
       disable: false
     googleAnalytics:
-      anonymizeIP: false
       disable: false
       respectDoNotTrack: false
-      useSessionStorage: false
     instagram:
       disable: false
       simple: false
index a3b09e369e06fb55d3aab276234dfecaf9689d6a..c409b0fbd35f6a4ab19c3799560a60d65281d07d 100644 (file)
@@ -15,8 +15,6 @@ package hugolib
 
 import (
        "testing"
-
-       qt "github.com/frankban/quicktest"
 )
 
 func TestInternalTemplatesImage(t *testing.T) {
@@ -97,43 +95,6 @@ title: My Site
 `)
 }
 
-// Just some simple test of the embedded templates to avoid
-// https://github.com/gohugoio/hugo/issues/4757 and similar.
-func TestEmbeddedTemplates(t *testing.T) {
-       t.Parallel()
-
-       c := qt.New(t)
-       c.Assert(true, qt.Equals, true)
-
-       home := []string{"index.html", `
-GA:
-{{ template "_internal/google_analytics.html" . }}
-
-GA async:
-
-{{ template "_internal/google_analytics_async.html" . }}
-
-Disqus:
-
-{{ template "_internal/disqus.html" . }}
-
-`}
-
-       b := newTestSitesBuilder(t)
-       b.WithSimpleConfigFile().WithTemplatesAdded(home...)
-
-       b.Build(BuildCfg{})
-
-       // Gheck GA regular and async
-       b.AssertFileContent("public/index.html",
-               "'anonymizeIp', true",
-               "'script','https://www.google-analytics.com/analytics.js','ga');\n\tga('create', 'UA-ga_id', 'auto')",
-               "<script async src='https://www.google-analytics.com/analytics.js'>")
-
-       // Disqus
-       b.AssertFileContent("public/index.html", "\"disqus_shortname\" + '.disqus.com/embed.js';")
-}
-
 func TestEmbeddedPaginationTemplate(t *testing.T) {
        t.Parallel()
 
index e2bd57f3c7cb9879157001ca11101c8d9d9472e2..dab6936235cb7e1219346520ab59412beba27579 100644 (file)
@@ -258,7 +258,6 @@ id = "UA-ga_id"
 disable = false
 [privacy.googleAnalytics]
 respectDoNotTrack = true
-anonymizeIP = true
 [privacy.instagram]
 simple = true
 [privacy.twitter]
index c9a12e8e9d36904408e7f8c14e400570b4876faf..b8930d4bd277b70f9eeca76cd63df1fe281a82db 100644 (file)
@@ -1,51 +1,22 @@
-{{- $pc := .Site.Config.Privacy.GoogleAnalytics -}}
-{{- if not $pc.Disable }}{{ with .Site.Config.Services.GoogleAnalytics.ID -}}
-{{ if hasPrefix . "G-"}}
-<script async src="https://www.googletagmanager.com/gtag/js?id={{ . }}"></script>
-<script>
-{{ template "__ga_js_set_doNotTrack" $ }}
-if (!doNotTrack) {
-       window.dataLayer = window.dataLayer || [];
-       function gtag(){dataLayer.push(arguments);}
-       gtag('js', new Date());
-       gtag('config', '{{ . }}', { 'anonymize_ip': {{- $pc.AnonymizeIP -}} });
-}
-</script>
-{{ else if hasPrefix . "UA-" }}
-<script>
-{{ template "__ga_js_set_doNotTrack" $ }}
-if (!doNotTrack) {
-       (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
-       (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
-       m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
-       })(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
-       {{- if $pc.UseSessionStorage }}
-       if (window.sessionStorage) {
-               var GA_SESSION_STORAGE_KEY = 'ga:clientId';
-               ga('create', '{{ . }}', {
-           'storage': 'none',
-           'clientId': sessionStorage.getItem(GA_SESSION_STORAGE_KEY)
-          });
-          ga(function(tracker) {
-           sessionStorage.setItem(GA_SESSION_STORAGE_KEY, tracker.get('clientId'));
-          });
-   }
-       {{ else }}
-       ga('create', '{{ . }}', 'auto');
-       {{ end -}}
-       {{ if $pc.AnonymizeIP }}ga('set', 'anonymizeIp', true);{{ end }}
-       ga('send', 'pageview');
-}
-</script>
-{{- end -}}
-{{- end }}{{ end -}}
-
-{{- define "__ga_js_set_doNotTrack" -}}{{/* This is also used in the async version. */}}
-{{- $pc := .Site.Config.Privacy.GoogleAnalytics -}}
-{{- if not $pc.RespectDoNotTrack -}}
-var doNotTrack = false;
-{{- else -}}
-var dnt = (navigator.doNotTrack || window.doNotTrack || navigator.msDoNotTrack);
-var doNotTrack = (dnt == "1" || dnt == "yes");
-{{- end -}}
-{{- end -}}
+{{ if not site.Config.Privacy.GoogleAnalytics.Disable }}
+  {{ with site.Config.Services.GoogleAnalytics.ID }}
+    {{ if strings.HasPrefix (lower .) "ua-" }}
+      {{ warnf "Google Analytics 4 (GA4) replaced Google Universal Analytics (UA) effective 1 July 2023. See https://support.google.com/analytics/answer/11583528. Create a GA4 property and data stream, then replace the Google Analytics ID in your site configuration with the new value." }}
+    {{ else }}
+      <script async src="https://www.googletagmanager.com/gtag/js?id={{ . }}"></script>
+      <script>
+        var doNotTrack = false;
+        if ({{ site.Config.Privacy.GoogleAnalytics.RespectDoNotTrack }}) {
+          var dnt = (navigator.doNotTrack || window.doNotTrack || navigator.msDoNotTrack);
+          var doNotTrack = (dnt == "1" || dnt == "yes");
+        }
+        if (!doNotTrack) {
+          window.dataLayer = window.dataLayer || [];
+          function gtag(){dataLayer.push(arguments);}
+          gtag('js', new Date());
+          gtag('config', '{{ . }}');
+        }
+      </script>
+    {{ end }}
+  {{ end }}
+{{ end }}
diff --git a/tpl/tplimpl/embedded/templates/google_analytics_async.html b/tpl/tplimpl/embedded/templates/google_analytics_async.html
deleted file mode 100644 (file)
index 93ecb75..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-{{ warnf "_internal/google_analytics_async.html is no longer supported by Google and will be removed in a future version of Hugo" }}
-{{- $pc := .Site.Config.Privacy.GoogleAnalytics -}}
-{{- if not $pc.Disable -}}
-{{ with .Site.Config.Services.GoogleAnalytics.ID }}
-<script>
-{{ template "__ga_js_set_doNotTrack" $ }}
-if (!doNotTrack) {
-       window.ga=window.ga||function(){(ga.q=ga.q||[]).push(arguments)};ga.l=+new Date;
-       {{- if $pc.UseSessionStorage }}
-       if (window.sessionStorage) {
-               var GA_SESSION_STORAGE_KEY = 'ga:clientId';
-               ga('create', '{{ . }}', {
-           'storage': 'none',
-           'clientId': sessionStorage.getItem(GA_SESSION_STORAGE_KEY)
-          });
-          ga(function(tracker) {
-           sessionStorage.setItem(GA_SESSION_STORAGE_KEY, tracker.get('clientId'));
-          });
-   }
-       {{ else }}
-       ga('create', '{{ . }}', 'auto');
-       {{ end -}}
-       {{ if $pc.AnonymizeIP }}ga('set', 'anonymizeIp', true);{{ end }}
-       ga('send', 'pageview');
-}
-</script>
-<script async src='https://www.google-analytics.com/analytics.js'></script>
-{{ end }}
-{{- end -}}
index 1b2cffce6792cadea839d3580d8ead211edd8dca..abda3af29a0d3db4805e1bac8def36684e9ed1a9 100644 (file)
@@ -210,3 +210,47 @@ var a = §§{{.Title }}§§;
        // This used to fail, but not in >= Hugo 0.121.0.
        b.Assert(err, qt.IsNil)
 }
+
+func TestGoogleAnalyticsTemplate(t *testing.T) {
+       t.Parallel()
+
+       files := `
+-- hugo.toml --
+disableKinds = ['page','section','rss','sitemap','taxonomy','term']
+[privacy.googleAnalytics]
+disable = false
+respectDoNotTrack = true
+[services.googleAnalytics]
+id = 'G-0123456789'
+-- layouts/index.html --
+{{ template "_internal/google_analytics.html" . }}
+`
+
+       b := hugolib.Test(t, files)
+
+       b.AssertFileContent("public/index.html",
+               `<script async src="https://www.googletagmanager.com/gtag/js?id=G-0123456789"></script>`,
+               `var dnt = (navigator.doNotTrack || window.doNotTrack || navigator.msDoNotTrack);`,
+       )
+}
+
+func TestDisqusTemplate(t *testing.T) {
+       t.Parallel()
+
+       files := `
+-- hugo.toml --
+disableKinds = ['page','section','rss','sitemap','taxonomy','term']
+[services.disqus]
+shortname = 'foo'
+[privacy.disqus]
+disable = false
+-- layouts/index.html --
+{{ template "_internal/disqus.html" . }}
+`
+
+       b := hugolib.Test(t, files)
+
+       b.AssertFileContent("public/index.html",
+               `s.src = '//' + "foo" + '.disqus.com/embed.js';`,
+       )
+}